Skip to content

Comments

Sync desktop/ from omi-desktop (474e1e1f)#4969

Open
m13v wants to merge 1 commit intomainfrom
sync/desktop-20260222-173638
Open

Sync desktop/ from omi-desktop (474e1e1f)#4969
m13v wants to merge 1 commit intomainfrom
sync/desktop-20260222-173638

Conversation

@m13v
Copy link
Collaborator

@m13v m13v commented Feb 22, 2026

Automated sync from omi-desktop at 474e1e1f.

This PR was created by the sync pipeline.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is an automated sync that introduces a wide range of significant improvements and refactorings. Key changes include the unification of the AI chat bridge into a single, more robust ACP-based implementation with support for user-provided Claude accounts via OAuth. The task management UI/UX has been overhauled with features like cross-category drag-and-drop, inline task creation, and interactive badges for tags and priority. There are also critical stability fixes, such as an auto-restart mechanism for extreme memory usage and watchdogs to prevent hung ffmpeg processes. Overall, this is a massive and impressive update that enhances features, stability, and maintainability across the application.

I am having trouble creating individual review comments. Click here to see my feedback.

desktop/Desktop/Sources/AgentSyncService.swift (351-359)

high

The logic for handling non-200 status codes contains duplicated code for logging the response body in the else if and else blocks. This can be refactored to remove the repetition, which will make the code cleaner and easier to maintain.

            if httpResponse.statusCode == 200 {
                return .success
            }

            let body = String(data: data, encoding: .utf8) ?? ""
            log("AgentSync: push \(table) failed — HTTP \(httpResponse.statusCode): \(body)")

            if httpResponse.statusCode >= 500 {
                return .networkError  // 5xx = server not ready, trigger backoff
            }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant