Fix concurrent evaluation of static variables used from xquery:fork-join#2688
Open
GuntherRademacher wants to merge 1 commit into
Open
Fix concurrent evaluation of static variables used from xquery:fork-join#2688GuntherRademacher wants to merge 1 commit into
xquery:fork-join#2688GuntherRademacher wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Static variables are evaluated at most once per query, involving a circular dependency check, but this was triggered incorrectly when variable values were accessed and evaluated concurrently by multiple threads started via
xquery:fork-join.The changes here
dontEnterruntime check with query-local static-variable evaluation coordinationstaticVarWaitingdependency map between parent and child query contextsvolatileso cached results can be read before entering synchronizationQueryException.DataandInputInfo.copy()so errors from failed static-variable evaluation can be reconstructed for waiting threads without sharing one mutableQueryExceptioninstanceRegression tests are added for #2678, including: