Capture context for partial function defaults in closures#2623
Merged
ChristianGruen merged 1 commit intoBaseXdb:mainfrom Mar 19, 2026
Merged
Conversation
Member
|
👍 Less code than I would have expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes in this PR fix the handling of context-dependent default parameters in partial function applications. The added code ensures the context item is captured at function item creation time, by adding it as an extra closure binding. This prevents incorrect
XPDY0002errors that occurred in QT4 test casesFunctionCall-427andFunctionCall-428.