Enhance permission checks and validation logic - #1842
Open
Spagles wants to merge 7 commits into
Open
Conversation
…ver-level permissions
…ent deletion logic
|
Member
|
Thanks for the PR. Can you clarify what the Number change is trying to fix? The underlying SQL driver should already be returning the correct type |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements include ensuring password verification only occurs if a password exists, enhancing rate limit bypass logic to consider server permissions, and refining permission checks for attachment creation. Additionally, ensure counts and comment IDs are properly converted to numbers before comparisons in multiple places.