Skip to content

Show the guest username in the lobby ready prompt #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
grapefizz wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Show the guest username in the lobby ready prompt #508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3806cdc
fix(lobby): show guest username in ready prompt
grapefizz Jul 23, 2026
f7b8e50
fix(lobby): uppercase guest name in ready prompt
grapefizz Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion localization/en-us.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1197,7 +1197,7 @@ return {
},
b_wait_for_guest_ready = {
"WAITING FOR",
"GUEST TO READY UP",
"#1# TO READY UP",
},
b_lobby_options = "LOBBY OPTIONS",
b_copy_clipboard = "Copy to clipboard",
Expand Down
2 changes: 1 addition & 1 deletion localization/es_419.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -665,7 +665,7 @@ return {
},
b_wait_for_guest_ready = {
"ESPERANDO",
"AL INVITADO",
"A #1#",
},
b_lobby_options = "OPCIONES DE SALA",
b_copy_clipboard = "Copiar al portapapeles",
Expand Down
2 changes: 1 addition & 1 deletion localization/it.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,7 +482,7 @@ return {
},
b_wait_for_guest_ready = {
"IN ATTESA",
"DEGLI OSPITI",
"DI #1#",
},
b_lobby_options = "OPZIONI LOBBY",
b_copy_clipboard = "Copia negli Appunti",
Expand Down
2 changes: 1 addition & 1 deletion localization/ja.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,7 +506,7 @@ return {
"待っています...",
},
b_wait_for_guest_ready = {
"全員の準備完了まで",
"#1#の準備完了まで",
"お待ちください",
},
b_lobby_options = "ロビー設定",
Expand Down
2 changes: 1 addition & 1 deletion localization/ko.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -705,7 +705,7 @@ return {
},
b_wait_for_guest_ready = {
"대기 중:",
"게스트 준비",
"#1# 준비",
},
b_lobby_options = "로비 옵션",
b_copy_clipboard = "클립보드로 복사",
Expand Down
2 changes: 1 addition & 1 deletion localization/ru.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1183,7 +1183,7 @@ return {
},
b_wait_for_guest_ready = {
"ЖДЁМ",
"ГОТОВНОСТИ ГОСТЯ",
"ГОТОВНОСТИ #1#",
},
b_lobby_options = "ПАРАМЕТРЫ ЛОББИ",
b_copy_clipboard = "Скопировать",
Expand Down
6 changes: 3 additions & 3 deletions localization/vi.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -831,8 +831,8 @@ return {
"NGƯỜI CHƠI",
},
b_wait_for_guest_ready = {
"ĐANG CHỜ NGƯỜI CHƠI",
"KHÁC SẴN SÀNG",
"ĐANG CHỜ #1#",
"SẴN SÀNG",
},
b_lobby_options = "TUỲ CHỈNH PHÒNG",
b_copy_clipboard = "Sao chép vào bộ nhớ đệm",
Expand Down Expand Up @@ -1161,4 +1161,4 @@ return {
c_mp_shared_pockets = "Chung Túi",
},
},
}
}
2 changes: 1 addition & 1 deletion localization/zh_CN.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ return {
},
b_wait_for_guest_ready = {
"正在等待",
"访客",
"#1#",
},
b_lobby_options = "房间设置",
b_copy_clipboard = "复制到剪贴板",
Expand Down
3 changes: 2 additions & 1 deletion ui/lobby/start_ready_button.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,8 @@ function MP.UI.create_lobby_main_button(text_scale)
minw = 3.65,
minh = 1.55,
label = { localize("b_start") },
disabled_text = MP.LOBBY.guest.username and localize("b_wait_for_guest_ready")
disabled_text = MP.LOBBY.guest.username
and localize({ type = "variable", key = "b_wait_for_guest_ready", vars = { string.upper(MP.LOBBY.guest.username) } })
or localize("b_wait_for_players"),
scale = text_scale * 2,
col = true,
Expand Down