feat(practice): ghost replay system — play against the dead#379
Draft
stephenkirk wants to merge 35 commits intodevfrom
Draft
feat(practice): ghost replay system — play against the dead#379stephenkirk wants to merge 35 commits intodevfrom
stephenkirk wants to merge 35 commits intodevfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Practice mode had no opponent. You could test builds against vanilla blinds, but the PvP blinds — the part that actually matters — required a second human. Ghost replays let you practice against recorded match data instead.
Summary
lib/log_parser.lua) and standalone Python/HTML tools (tools/).lib/match_history.lua) stores completed MP games as replayable ghost data.Isolation fixes
action_start_gameclearsMP.SP.practiceandMP.GHOSTon both host and client paths, preventing stale ghost state from leaking into real MP.ease_anteevent suppression patch extended to ghost mode, fixing double ante increment.MP.LOBBY.configand similar still needs migration toMP.GHOST.gamemodeto prevent config bleed into subsequent lobbies.What it doesn't do
Test plan