Skip to content

Correct gl_FragCoord Y orientation on D3D, Metal and Vulkan #1840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bkaradzic-microsoft wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Correct gl_FragCoord Y orientation on D3D, Metal and Vulkan #1840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4f29acf
Fix gl_FragCoord Y orientation on D3D/Metal/Vulkan
bkaradzic Aug 17, 2026
1a24718
Add unit tests pinning down gl_FragCoord orientation
bkaradzic Aug 18, 2026
9f2e2bc
Use null instead of delete to disable parallel shader compile
bkaradzic Aug 18, 2026
666e1ad
Make the gl_FragCoord orientation test backend-agnostic
bkaradzic Aug 18, 2026
ccc6efe
Bump Babylon.js from 9.15.0 to 9.21.2
bkaradzic Aug 18, 2026
b6bc698
Enable 9 validation tests fixed by the Babylon.js 9.21.2 bump
bkaradzic Aug 18, 2026
2eaaf94
Restore the original basic type when narrowing widened uniforms
bkaradzic Aug 18, 2026
e6c431e
Re-exclude Prepass SSAO + particles for a Mesa/LLVM crash
bkaradzic Aug 19, 2026
e5490d2
Exclude the prepass SSAO tests for a Mesa/LLVM crash on the CI runner
bkaradzic Aug 19, 2026
6850884
Enable GUI Near Menu on OpenGL and exclude Screen Space Reflections 2
bkaradzic Aug 19, 2026
fd43a00
Downlevel the Babylon.js bundles to ES5 after npm install
bkaradzic Aug 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 17 additions & 21 deletions Apps/Playground/Scripts/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -833,8 +833,6 @@
{
"title": "Volumetric Light Scattering Post Process with Morph Targets",
"playgroundId": "#5E318S#7",
"excludeFromAutomaticTesting": true,
"reason": "Pixel comparison fails on Linux (large diff)",
"referenceImage": "volumetricLightScatteringMorphTargets.png"
},
{
Expand Down Expand Up @@ -1092,8 +1090,6 @@
"title": "GUI Near Menu",
"playgroundId": "#2YZFA0#302",
"renderCount": 60,
"excludedGraphicsApis": ["OpenGL"],
"reason": "OpenGL: BGFX FATAL shader compile error in GUI fragment shader ('=' : cannot convert from 'highp float' to 'bool'). Re-enabled on D3D11 post BabylonJS/BabylonNative#1695 (original 'V8 D3D11 crash' no longer reproduces under Chakra; original 'hangs on OpenGL' is now this clean shader-compile failure surfaced by the BabylonJS/BabylonNative#1688 BgfxCallback).",
"referenceImage": "guiNearMenu.png"
},
{
Expand Down Expand Up @@ -1843,9 +1839,9 @@
"title": "Prepass SSAO + particles",
"playgroundId": "#65MUMZ#47",
"renderCount": 50,
"referenceImage": "prepass-ssao-particles.png",
"excludeFromAutomaticTesting": true,
"reason": "SSAO2 blur post-process shader fails to compile on desktop GL (samples uniform used as int loop bound); unrelated to instancing.",
"referenceImage": "prepass-ssao-particles.png"
"reason": "llvmpipe on the Ubuntu CI runner aborts the process with LLVM ERROR: Cannot emit physreg copy instruction while JIT-compiling the prepass SSAO shaders (Mesa/LLVM register allocator bug, thrown before pixel comparison, not a pixel-diff); the test passes on D3D11 and on ANGLE/GLES"
},
{
"title": "Prepass SSAO + instances",
Expand All @@ -1858,9 +1854,9 @@
"title": "Prepass SSAO + instanced bones",
"playgroundId": "#0K8EYN#197",
"renderCount": 50,
"referenceImage": "prepass-ssao-instanced-bones.png",
"excludeFromAutomaticTesting": true,
"reason": "Test crashes or hangs on Babylon Native",
"referenceImage": "prepass-ssao-instanced-bones.png"
"reason": "llvmpipe on the Ubuntu CI runner aborts the process with LLVM ERROR: Cannot emit physreg copy instruction while JIT-compiling the prepass SSAO shaders (Mesa/LLVM register allocator bug, thrown before pixel comparison, not a pixel-diff); the test passes on D3D11 and on ANGLE/GLES"
},
{
"title": "Prepass SSAO + depth of field",
Expand Down Expand Up @@ -1937,10 +1933,10 @@
{
"title": "Prepass SSAO + GUI",
"playgroundId": "#LLVZ90#4",
"excludeFromAutomaticTesting": true,
"reason": "Order-dependent state leak: passes in isolation but produces ~6000-px diff (right at 2.5% errorRatio threshold, flaky in CI) when run after sibling Prepass-SSAO tests in the full sweep on Win32 D3D11. OpenGL also fails (BGFX FATAL 'mediump float' shader compile in PrePassRenderer fragment shader). Re-enable after the order-dependent SSAO state cleanup is investigated.",
"renderCount": 10,
"referenceImage": "prepass-ssao-gui.png"
"referenceImage": "prepass-ssao-gui.png",
"excludeFromAutomaticTesting": true,
"reason": "llvmpipe on the Ubuntu CI runner aborts the process with LLVM ERROR: Cannot emit physreg copy instruction while JIT-compiling the prepass SSAO shaders (Mesa/LLVM register allocator bug, thrown before pixel comparison, not a pixel-diff); the test passes on D3D11 and on ANGLE/GLES"
},
{
"title": "Prepass SSAO + LOD",
Expand All @@ -1962,9 +1958,9 @@
"title": "Prepass SSAO + highlight layer",
"playgroundId": "#1KUJ0A#416",
"renderCount": 10,
"referenceImage": "prepass-ssao-highlight-layer.png",
"excludeFromAutomaticTesting": true,
"reason": "Test crashes or hangs on Babylon Native",
"referenceImage": "prepass-ssao-highlight-layer.png"
"reason": "llvmpipe on the Ubuntu CI runner aborts the process with LLVM ERROR: Cannot emit physreg copy instruction while JIT-compiling the prepass SSAO shaders (Mesa/LLVM register allocator bug, thrown before pixel comparison, not a pixel-diff); the test passes on D3D11 and on ANGLE/GLES"
},
{
"title": "Prepass SSAO + point light",
Expand All @@ -1978,25 +1974,25 @@
"title": "Prepass SSAO + on/off post-process",
"playgroundId": "#1VI6WV#20",
"renderCount": 10,
"referenceImage": "prepass-ssao-on-off-pp.png",
"excludeFromAutomaticTesting": true,
"reason": "Test crashes or hangs on Babylon Native",
"referenceImage": "prepass-ssao-on-off-pp.png"
"reason": "llvmpipe on the Ubuntu CI runner aborts the process with LLVM ERROR: Cannot emit physreg copy instruction while JIT-compiling the prepass SSAO shaders (Mesa/LLVM register allocator bug, thrown before pixel comparison, not a pixel-diff); the test passes on D3D11 and on ANGLE/GLES"
},
{
"title": "Prepass SSAO + thin instances",
"playgroundId": "#V1JE4Z#25",
"renderCount": 10,
"referenceImage": "prepass-ssao-thin-instances.png",
"excludeFromAutomaticTesting": true,
"reason": "Test crashes or hangs on Babylon Native",
"referenceImage": "prepass-ssao-thin-instances.png"
"reason": "llvmpipe on the Ubuntu CI runner aborts the process with LLVM ERROR: Cannot emit physreg copy instruction while JIT-compiling the prepass SSAO shaders (Mesa/LLVM register allocator bug, thrown before pixel comparison, not a pixel-diff); the test passes on D3D11 and on ANGLE/GLES"
},
{
"title": "Prepass SSAO + depth renderer",
"playgroundId": "#3HPMAA#1",
"renderCount": 10,
"referenceImage": "prepass-ssao-depth-renderer.png",
"excludeFromAutomaticTesting": true,
"reason": "Test crashes or hangs on Babylon Native",
"referenceImage": "prepass-ssao-depth-renderer.png"
"reason": "llvmpipe on the Ubuntu CI runner aborts the process with LLVM ERROR: Cannot emit physreg copy instruction while JIT-compiling the prepass SSAO shaders (Mesa/LLVM register allocator bug, thrown before pixel comparison, not a pixel-diff); the test passes on D3D11 and on ANGLE/GLES"
},
{
"title": "Prepass SSAO + visibility",
Expand Down Expand Up @@ -2378,9 +2374,9 @@
"title": "Screen Space Reflections 2",
"playgroundId": "#PIZ1GK#1500",
"renderCount": 5,
"referenceImage": "Screen-Space-Reflections-2.png",
"excludeFromAutomaticTesting": true,
"reason": "NativeEngine Screen Space Reflections do not render the wet/reflective floor surface; SSR effect produces less reflection than WebGL reference.",
"referenceImage": "Screen-Space-Reflections-2.png"
"reason": "OpenGL ES: bgfx FrameBufferGL::resolve calls glDrawBuffers(1, &GL_COLOR_ATTACHMENT0 + colorIdx), but GLES requires bufs[i] to be GL_NONE or GL_COLOR_ATTACHMENT0 + i, so resolving any attachment past the first raises GL_INVALID_OPERATION and asserts (bgfx bug, thrown before pixel comparison, not a pixel-diff); the test passes on D3D11"
},
{
"title": "MultiRenderTarget with different texture types",
Expand Down
1 change: 1 addition & 0 deletions Apps/UnitTests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ set(SOURCES
"Source/Tests.NativeEngine.Teardown.cpp"
"Source/Tests.ShaderCache.cpp"
"Source/Tests.ShaderCompilation.cpp"
"Source/Tests.ShaderCompilation.FragCoord.cpp"
"Source/Tests.UniformPadding.cpp"
"Source/Helpers.h"
"Source/Helpers.${GRAPHICS_API}.${BABYLON_NATIVE_PLATFORM_IMPL_EXT}")
Expand Down
Loading
Loading