disable non working vis tests macOS#1772
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts Babylon Native’s macOS visual-test harness and Playground validation configuration to avoid known-failing/crashing visual tests when running with Metal on macOS, while also correcting the test window sizing behavior on Retina displays to better match reference-image dimensions.
Changes:
- Update macOS
TestUtils::UpdateSizeto set the NSWindow content size directly (in logical points) instead of dividing bybackingScaleFactor, preventing half-resolution backbuffers on Retina. - Mark a set of known-problematic validation tests as excluded for the
Metalgraphics API (with reasons) in the Playgroundconfig.json.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Plugins/TestUtils/Source/TestUtils_macOS.mm | Fixes macOS test window sizing so the produced backbuffer resolution matches expected reference-image dimensions on Retina. |
| Apps/Playground/Scripts/config.json | Excludes specific visual tests from running under Metal (macOS) due to crashes or pixel-diff mismatches, with documented reasons. |
bkaradzic-microsoft
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.