test VT runner#1771
Closed
CedricGuillemet wants to merge 1 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a macOS visualization-test lane that reuses the default macOS build output by publishing Playground.app as an artifact, then running pixel-diff validation on a self-hosted runner intended to have a real Metal GPU. The PR also comments out non-macOS CI jobs in the main CI workflow.
Changes:
- Add an optional
upload-visualization-artifactinput to the macOS reusable workflow and package/uploadPlayground.appas a tarball artifact. - Add a
MacOS_VisualizationTestsjob that downloads the artifact and runsvalidation_native.json a self-hosted runner. - Temporarily disable (comment out) most non-macOS CI jobs in
.github/workflows/ci.yml.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/ci.yml | Enables artifact publishing for the default macOS build, adds a self-hosted visualization test job, and comments out non-macOS jobs. |
| .github/workflows/build-macos.yml | Adds a workflow input and steps to package/upload the Playground app for downstream visualization testing. |
Comment on lines
+45
to
+48
| MacOS_VisualizationTests: | ||
| needs: MacOS | ||
| runs-on: self-hosted | ||
| timeout-minutes: 60 |
Comment on lines
+71
to
+73
| # ══════════════════════════════════════════════════════════════════ | ||
| # All non-macOS CI has been temporarily disabled. Uncomment to restore. | ||
| # ══════════════════════════════════════════════════════════════════ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.