Add OpenGLWindowsDevOnly graphics API for Windows#1655
Merged
bkaradzic-microsoft merged 5 commits intomasterfrom Apr 10, 2026
Merged
Add OpenGLWindowsDevOnly graphics API for Windows#1655bkaradzic-microsoft merged 5 commits intomasterfrom
bkaradzic-microsoft merged 5 commits intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Enables selecting the OpenGL (bgfx OpenGLES) renderer on Windows builds by relaxing CMake validation and removing an EGL header dependency from the OpenGL renderer-type header.
Changes:
- Remove
EGL/egl.hdependency from the OpenGL renderer-type header and makeDeviceTan opaque pointer. - Allow
-DGRAPHICS_API=OpenGLon Windows in the root CMake validation logic.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Core/Graphics/Include/RendererType/OpenGL/Babylon/Graphics/RendererType.h | Makes the OpenGL “device/context” handle opaque to avoid requiring EGL headers. |
| CMakeLists.txt | Permits GRAPHICS_API=OpenGL on Windows by expanding the accepted renderer list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Core/Graphics/Include/RendererType/OpenGL/Babylon/Graphics/RendererType.h
Outdated
Show resolved
Hide resolved
bghgary
reviewed
Apr 9, 2026
Core/Graphics/Include/RendererType/OpenGL/Babylon/Graphics/RendererType.h
Outdated
Show resolved
Hide resolved
…dererType.h Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
bkaradzic-microsoft
changed the title
bghgary
approved these changes
Apr 10, 2026
Contributor
bghgary
left a comment
bghgary
left a comment
There was a problem hiding this comment.
Small comment. Looks good otherwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gate OpenGLES on Windows behind -DGRAPHICS_API=OpenGLWindowsDevOnly. CMake finds libEGL.dll and libGLESv2.dll from the Edge or Chrome installation via the App Paths registry key and copies them into the executable output directory at build time. Edge is tried first since it ships with Windows, followed by Chrome.