Skip to content

Removed DeviceUpdate.#1653

Draft
bkaradzic-microsoft wants to merge 1 commit intorework-thread-modelfrom
remove-device-update
Draft

Removed DeviceUpdate.#1653
bkaradzic-microsoft wants to merge 1 commit intorework-thread-modelfrom
remove-device-update

Conversation

@bkaradzic-microsoft
Copy link
Copy Markdown
Contributor

Depends on rework-thread-model branch.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the deprecated Babylon::Graphics::DeviceUpdate compatibility shim and updates samples/apps/tests to rely solely on Device::StartRenderingCurrentFrame() / Device::FinishRenderingCurrentFrame() for frame synchronization.

Changes:

  • Deleted DeviceUpdate and Device::GetUpdate() from the public graphics device header.
  • Removed DeviceUpdate usage across unit tests and sample applications.
  • Updated ExternalTexture documentation examples to no longer reference DeviceUpdate.

Reviewed changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
Plugins/ExternalTexture/Readme.md Removes DeviceUpdate calls from the D3D12 example snippet.
Core/Graphics/Include/Shared/Babylon/Graphics/Device.h Removes deprecated DeviceUpdate type and GetUpdate() API.
Apps/UnitTests/Source/Tests.UniformPadding.cpp Drops DeviceUpdate usage around frame start/finish.
Apps/UnitTests/Source/Tests.ShaderCache.cpp Drops DeviceUpdate usage in frame-pumping loop.
Apps/UnitTests/Source/Tests.ExternalTexture.D3D11.cpp Drops DeviceUpdate usage (minor formatting/spelling nits remain).
Apps/UnitTests/Source/Tests.ExternalTexture.cpp Drops DeviceUpdate usage around frame boundaries.
Apps/UnitTests/Source/Tests.Device.D3D11.cpp Drops DeviceUpdate usage inside back-buffer iteration.
Apps/StyleTransferApp/Win32/App.cpp Removes g_update lifecycle and frame sync calls.
Apps/PrecompiledShaderTest/Source/App.cpp Removes deviceUpdate from render/unblock sequencing.
Apps/Playground/X11/App.cpp Removes DeviceUpdate() calls from the main loop tick.
Apps/Playground/Win32/App.cpp Removes DeviceUpdate() calls from loop and suspend/resume paths.
Apps/Playground/visionOS/LibNativeBridge.mm Removes DeviceUpdate() calls from resize/render callbacks.
Apps/Playground/UWP/App.cpp Removes DeviceUpdate() calls from run loop and suspend/resume.
Apps/Playground/Shared/AppContext.h Removes DeviceUpdate() accessor and stored optional.
Apps/Playground/Shared/AppContext.cpp Removes m_deviceUpdate initialization/teardown and usage.
Apps/Playground/macOS/ViewController.mm Removes DeviceUpdate() calls from Metal view callbacks.
Apps/Playground/iOS/LibNativeBridge.mm Removes DeviceUpdate() calls from resize/render entrypoints.
Apps/Playground/Android/BabylonNative/src/main/cpp/BabylonNativeJNI.cpp Removes DeviceUpdate() calls from JNI render tick.
Apps/HeadlessScreenshotApp/Win32/App.cpp Removes deviceUpdate usage from headless render flow.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants