Add access control filtering for protein_structure queries#151
Open
olsonanl wants to merge 1 commit intoBV-BRC:alphafrom
Open
Add access control filtering for protein_structure queries#151olsonanl wants to merge 1 commit intoBV-BRC:alphafrom
olsonanl wants to merge 1 commit intoBV-BRC:alphafrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Protein structure records were being returned without access control checks. Since protein_structure was in the publicFree list, queries would return structures linked to private genomes that users should not have access to.
Solution
Implement join-based access control that:
Files Changed
Related
This PR should be deployed alongside BV-BRC/BV-BRC-Web#1221 which adds the UI for creating genome/feature groups from protein structure selections.
Test plan
Generated with Claude Code