3 eln/tutorial eln/review from CD (so far)#2
Open
caro-demi wants to merge 5 commits into
Open
Conversation
…k capitalised. mentioned important definitions can be linked to Wiki (Lab Notebook, Inventory, Entity, Space, Project, etc.) Figure 6: (different description in screenshot and in playground.) Detailed information about rights and roles can be found in the Data Store wiki. - link is missing Figure 11, 12, 13: ( figures need to be updated, no collection Structure_TEM) Fig. 12 and 13 are not described in text and purpose of them is not clear. Masterdata definitions process - link to Wiki Figure 14, 15, 16 - needs to be updated, no object Demo_001
angelaari
requested changes
May 26, 2026
Collaborator
angelaari
left a comment
angelaari
left a comment
There was a problem hiding this comment.
The Branch shows Merge conflicts, please resolve before sending request for next review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
overall comments to tutorial. exprimental step - not capitalised, but Lab Notebook capitalised.
mentioned important definitions can be linked to Wiki (Lab Notebook, Inventory, Entity, Space, Project, etc.)
Figure 6: (different description in screenshot and in playground.)
Detailed information about rights and roles can be found in the Data Store wiki. - link is missing
Figure 11, 12, 13: ( figures need to be updated, no collection Structure_TEM)
Fig. 12 and 13 are not described in text and purpose of them is not clear.
Masterdata definitions process - link to Wiki
Figure 14, 15, 16 - needs to be updated, no object Demo_001.
This is a review so far, will continue on monday.