88 Added documentation and updated benchmark pipeline for rotating-cylinders 2D#89
Open
Sarbani-Roy wants to merge 4 commits into
Open
88 Added documentation and updated benchmark pipeline for rotating-cylinders 2D#89Sarbani-Roy wants to merge 4 commits into
Sarbani-Roy wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #88
Summary
Adds documentation for the rotating-cylinders 2D benchmark and scripts to generate plots for DuMux and OpenFOAM.
Changes
Documentation (
docs/benchmarks/rotating_cylinders/)plots, radial profiles, and 2D field plots
Benchmark cases (
benchmarks/rotating-cylinders/)output_template.zipcompute_l2_error.pyadded for OpenFOAM L² error computation; outputssolution_metrics.jsonconsistent with the DuMux pipelineplot_results.pyadded for both solvers to generate documentation plotsplot_convergence.pyadded for per-solver and cross-solver convergence plotsNotes
plot_results.pyandplot_convergence.pyare used for plot generation related to documentation but can be removed if deemed redundant