Remove deleted gradle API used by buildsystem plugin, Fixes AB#3689387#444
Remove deleted gradle API used by buildsystem plugin, Fixes AB#3689387#444ridam-arora wants to merge 4 commits into
Conversation
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
ridam-arora
changed the title
ridam-arora
changed the title
|
@microsoft-github-policy-service agree company="Microsoft" |
ridam-arora
changed the title
|
✅ Work item link check complete. Description contains link AB#3689387 to an Azure Boards work item. |
|
❌ Invalid work item number: AB#3689387 Changes. Work item number must be a valid integer. Click here to learn more. |
There was a problem hiding this comment.
Pull request overview
Updates the internal plugins/buildsystem Gradle plugin to avoid Gradle 9+ removed APIs by switching Java compatibility configuration to JavaPluginExtension, and adds internal feed publishing configuration for the plugin artifact.
Changes:
- Replace legacy Java compatibility configuration with
JavaPluginExtension#setSourceCompatibility/#setTargetCompatibility. - Add a changelog entry for the Gradle API migration.
- Bump plugin version and add
publishingrepository config targeting the NewAndroid Azure Artifacts feed.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| plugins/buildsystem/src/main/java/com/microsoft/identity/buildsystem/BuildPlugin.java | Switch Java source/target compatibility configuration to JavaPluginExtension (Gradle 9+ compatible). |
| plugins/buildsystem/changelog | Add release notes entry documenting removal of deleted Gradle APIs. |
| plugins/buildsystem/build.gradle | Bump plugin version and add internal Azure Artifacts publishing repository configuration. |
|
|
||
| group 'com.microsoft.identity' | ||
| version '0.2.5' | ||
| version '0.2.6-dev' |
There was a problem hiding this comment.
This is now fixed in this PR
| username System.getenv("ENV_VSTS_MVN_CRED_USERNAME") != null ? System.getenv("ENV_VSTS_MVN_CRED_USERNAME") : project.findProperty("vstsUsername") | ||
| password System.getenv("ENV_VSTS_MVN_CRED_ACCESSTOKEN") != null ? System.getenv("ENV_VSTS_MVN_CRED_ACCESSTOKEN") : project.findProperty("vstsMavenAccessToken") |
There was a problem hiding this comment.
thanks, comment not applicable now as this change was removed from later commits
| @@ -1,5 +1,10 @@ | |||
| Plugin Overview: https://github.com/AzureAD/android-complete/blob/master/plugins/buildsystem/docs/Overview.md | |||
|
|
|||
| Version 0.2.6 | |||
There was a problem hiding this comment.
The changelog entries for 0.2.6 are both tagged [MINOR] but the version was bumped as a patch (0.2.5 → 0.2.6), not a minor (0.2.5 → 0.3.0).
There was a problem hiding this comment.
you're right, I would tag the changes as minor instead of patch, so I will need to change the artifact version, we may need to delete this 0.2.6 from maven feed though for consistency
AB#3689387
Changes the gradle API used by this plugin to set the sourceCompatibility and targetCompatibility properties. the API JavaPluginConvention has been deleted in gradle 9+