Remove download redirects, use cdn.dl.k8s.io domain#219
Conversation
|
@microsoft-github-policy-service agree company="Hanseaticsoft GmbH" |
davidgamero
left a comment
There was a problem hiding this comment.
lgtm thank you for the contribution!
|
Thank you so much @felix-mohr for this, and thank @davidgamero for review, seems like commit gatekeeping is not allowing to merge this, to enable if you have time @felix-mohr if you can please sign your commit, otherwise we can help and do that for you, as separate checkin. Whatever works the best. ❤️ |
|
@Tatsinnit Thank you. Never looked into signing commits, did not add much to public projects yet. Will try later this week and either replace the commit with a signed commit via force push (correct?) or ask you to do it in a new commit :-) |
Thank you so much @felix-mohr , sounds good, |
dl.k8s.io redirects to cdn.dl.k8s.io which somehow results in constants download errors on a self-hosted runner in the UAE region. Other regions were not affected. Updating the domains fixed the issue
Head branch was pushed to by a user without write access
20aff06 to
5a62f6e
Compare
|
@Tatsinnit I just signed and force-pushed the commit, I hope all is good now :-). No content changes, just amend the previous commit to sign it. |
|
Well, this is great.. Seems kubectl just removed the I could not find any information about this, except for the official download links not using the |
|
just saw the failing CI on this new PR #228 to revert to a working configuration with only links from the kubectl download docs https://kubernetes.io/docs/tasks/tools/install-kubectl-linux/
|
dl.k8s.io redirects to cdn.dl.k8s.io which somehow results in constants download errors on a self-hosted runner in the UAE region. Other regions were not affected. Updating the domains fixed the issue
The
helper.getLatestPatchVersionmethod already used the cdn domain