cp_acp: fix bugs in to_string.h and utf16_to_acp_impl, add tests#164
Merged
cp_acp: fix bugs in to_string.h and utf16_to_acp_impl, add tests#164
Conversation
added 5 commits
February 24, 2026 20:55
…w_to_span specialization, remove dead code
…r inheritance and operator<=>, expand tests
… createq event_kind, fix do_set_wait_until typo+cast, fix filetime_clock to_sys and now, expand tests
Add 20 new tests across the three test files: event (6 new): - IsValid: checks is_valid() on null/valid/reset event - MoveAssign: verifies move leaves source null and correct kind - CombinedFlagsInitialSetManualReset: initial_set|manual_reset - SetEventStateSetThenReset: set_event_state with WaitForSingleObject - AutoResetEventClearsAfterWait: auto-reset clears event after consume - SignalAndWaitAcrossThreads: threadpool callback signals event registry (8 new): - HkeyDefaultIsInvalid: default hkey is not valid/bool-true - HkeyPredefinedGet: get() round-trips the raw HKEY_CURRENT_USER value - HkeySwap: swap exchanges ownership of two opened hkeys - OpenqHappyPath: openq(HKCU\Software) succeeds, hkey is valid - OpenqFailurePath: openq on nonexistent key returns error, hkey stays null - OpenThrowsOnSuccess: open() succeeds and hkey is valid afterward - OpenThrowsOnFailure: open() on nonexistent key throws an exception - OpenqFromHkeyBase: openq(hkey&, ...) opens sub-key from opened root threadpool (6 new): - TpWorkMoveAssign: move-assign transfers ownership - TpWorkReset: reset() clears the tp_work - TpTimerConstructAndIsSet: construction + is_set() before arming - TpTimerSetAndCancel: arm far-future timer, verify is_set, cancel - TpTimerFiresAndWait: timer fires at epoch, event-based sync - TpWaitConstructAndSetWait: set_wait on pre-signaled event fires cb 36/36 debug and release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to clean up how cp_acp conversions are done