Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/Windows/libraries/windows_strings/src/char16_to_char.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,16 @@

namespace m
{
std::string
string_converter<char16_t const*, std::string>::make_string(cu16zstring str)
{
if (str == nullptr)
return std::string();

return string_converter<std::u16string_view, std::string>::make_string(
std::u16string_view(str));
}

std::string
string_converter<std::u16string_view, std::string>::make_string(std::u16string_view v)
{
Expand Down
6 changes: 6 additions & 0 deletions src/Windows/libraries/windows_strings/src/wchar_to_char.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@

namespace m
{
std::string
string_converter<wchar_t const*, std::string>::make_string(cwzstring str)
{
return string_converter<std::wstring_view, std::string>::make_string(view_of(str));
}

std::string
string_converter<std::wstring_view, std::string>::make_string(std::wstring_view v)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,11 @@ namespace m
std::u16string
string_converter<wchar_t const*, std::u16string>::make_string(cwzstring str)
{
return std::u16string(std::u16string_view(reinterpret_cast<char16_t const*>(str)));
if (str == nullptr)
return std::u16string();

return string_converter<std::wstring_view, std::u16string>::make_string(
std::wstring_view(str));
}

std::optional<std::u16string>
Expand Down
3 changes: 1 addition & 2 deletions src/libraries/Platform-Adaptive/strings/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,8 @@ target_compile_features(m_platform_adaptive_strings PUBLIC ${M_CXX_STD})

add_subdirectory(include)
add_subdirectory(src)
# add_subdirectory(test)
if(BUILD_TESTING)
# add_subdirectory(test)
add_subdirectory(test)
endif()

list(APPEND m_installation_targets
Expand Down
24 changes: 24 additions & 0 deletions src/libraries/Platform-Adaptive/strings/test/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
cmake_minimum_required(VERSION 3.23)

project(m)

include(GoogleTest)

set(TEST_EXE_NAME test_platform_adaptive_strings)

add_executable(${TEST_EXE_NAME}
test_platform_adaptive_strings.cpp
)

target_compile_features(${TEST_EXE_NAME} PUBLIC ${M_CXX_STD})

target_link_libraries(${TEST_EXE_NAME}
m_platform_adaptive_strings
GTest::gtest_main
)

enable_testing()

if(DISCOVER_TESTS)
gtest_discover_tests(${TEST_EXE_NAME})
endif()
Loading
Loading