Fix PostgreSQL health check connection string parsing #3083

Copilot · 2026-01-27T16:47:17Z

Fix PostgreSQL health check connection string handling

Summary

This PR fixes the health check endpoint failure for PostgreSQL data sources and adds comprehensive support for all database types.

Changes (4 files, 204 lines added, 3 lines modified):

Utilities.cs:
- Added MySQL connection string normalization support using MySqlConnectionStringBuilder
- Added optional ILogger parameter for logging exceptions
- Logs warnings when connection string parsing fails
HttpUtilities.cs: Updated to pass logger to NormalizeConnectionString
HealthCheckHelper.cs: Updated to pass DatabaseType parameter through the call chain
HealthCheckUtilitiesUnitTests.cs (NEW): Added 9 comprehensive unit tests covering:
- PostgreSQL normalization (including lowercase keywords bug fix)
- MSSQL normalization
- DWSQL normalization
- MySQL normalization
- Unsupported database types
- Malformed connection strings with and without logger
- Empty connection strings

Review Feedback Addressed

✅ Added MySQL connection string normalization for completeness
✅ Added logging instead of silently swallowing exceptions
✅ Added comprehensive unit test coverage (9 tests, all passing)

Security Summary

No security vulnerabilities detected by CodeQL
Changes follow existing patterns in the codebase
Exception handling prevents health check failures from malformed connection strings
Logging provides visibility into connection string parsing issues without exposing sensitive data

Original prompt

This section details on the original issue you should resolve

<issue_title>[Bug]: Health check fails to check postgres data-source</issue_title>
<issue_description>## What

When the health check attempts to check a Postgres data-source, it gets an error.

</issue_description>

<agent_instructions>Fix this with as few lines of new code as possible.</agent_instructions>

Comments on the Issue (you are @copilot in this section)
@JerryNixon # Solution
https://youtu.be/Js06lpu_YsM @ 5:00 time

#2797</comment_new>

Fixes [Bug]: Health check fails to check postgres data-source #2796

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: JerryNixon <1749983+JerryNixon@users.noreply.github.com>

Copilot

Pull request overview

This PR fixes PostgreSQL health check failures caused by connection string parsing errors. The issue occurred when direct assignment to DbConnection.ConnectionString bypassed Npgsql's parser, causing it to reject lowercase connection string keywords like host, port, and database.

Changes:

Added Utilities.NormalizeConnectionString() method to route connection strings through database-specific builders (NpgsqlConnectionStringBuilder for PostgreSQL, SqlConnectionStringBuilder for MSSQL/DWSQL)
Updated HttpUtilities.ExecuteDbQueryAsync() to accept DatabaseType parameter and apply connection string normalization
Threaded DatabaseType through HealthCheckHelper.ExecuteDatasourceQueryCheckAsync() to enable normalization

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
src/Service/HealthCheck/Utilities.cs	Added NormalizeConnectionString method to parse and normalize connection strings using database-specific builders
src/Service/HealthCheck/HttpUtilities.cs	Updated ExecuteDbQueryAsync to accept DatabaseType parameter and apply connection string normalization before creating database connection
src/Service/HealthCheck/HealthCheckHelper.cs	Updated ExecuteDatasourceQueryCheckAsync to pass DatabaseType parameter through to HttpUtilities for connection string normalization

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-27T20:16:46Z

src/Service/HealthCheck/Utilities.cs

+            switch (dbType)
+            {
+                case DatabaseType.PostgreSQL:
+                    return new NpgsqlConnectionStringBuilder(connectionString).ToString();
+                case DatabaseType.MSSQL:
+                case DatabaseType.DWSQL:
+                    return new SqlConnectionStringBuilder(connectionString).ToString();
+                default:
+                    return connectionString;
+            }


The NormalizeConnectionString method should handle exceptions from the connection string builders. Throughout the codebase (e.g., PostgreSqlMetadataProvider.TryGetSchemaFromConnectionString at src/Core/Services/MetadataProviders/PostgreSqlMetadataProvider.cs:47-58, RuntimeConfigLoader.GetPgSqlConnectionStringWithApplicationName at src/Config/RuntimeConfigLoader.cs:416-427), connection string builder instantiation is wrapped in try-catch blocks to handle potential parsing errors. If a malformed connection string is passed here, the exception will propagate up and may not be handled appropriately in the health check context. Consider wrapping the builder instantiation in a try-catch block and either logging the error and returning the original connection string, or allowing the exception to propagate with proper context.

Suggested change

switch (dbType)

{

case DatabaseType.PostgreSQL:

return new NpgsqlConnectionStringBuilder(connectionString).ToString();

case DatabaseType.MSSQL:

case DatabaseType.DWSQL:

return new SqlConnectionStringBuilder(connectionString).ToString();

default:

return connectionString;

}

try

{

switch (dbType)

{

case DatabaseType.PostgreSQL:

return new NpgsqlConnectionStringBuilder(connectionString).ToString();

case DatabaseType.MSSQL:

case DatabaseType.DWSQL:

return new SqlConnectionStringBuilder(connectionString).ToString();

default:

return connectionString;

}

}

catch (Exception)

{

// If the connection string cannot be parsed by the builder,

// return the original string to avoid failing the health check.

return connectionString;

}

Applied the suggested exception handling in commit d858f2d. The NormalizeConnectionString method now wraps the connection string builder instantiation in a try-catch block and returns the original connection string if parsing fails, preventing the health check from failing due to malformed connection strings.

JerryNixon · 2026-01-30T20:26:33Z

@copilot apply changes based on the comments in this thread

Co-authored-by: JerryNixon <1749983+JerryNixon@users.noreply.github.com>

Copilot · 2026-01-30T20:31:33Z

@copilot apply changes based on the comments in this thread

Changes applied in commit d858f2d. Added exception handling to the NormalizeConnectionString method to gracefully handle malformed connection strings.

Aniruddh25 · 2026-02-11T01:38:48Z

/azp run

azure-pipelines · 2026-02-11T01:39:09Z

Azure Pipelines successfully started running 6 pipeline(s).

souvikghosh04 · 2026-02-11T08:02:46Z

/azp run

azure-pipelines · 2026-02-11T08:03:14Z

Azure Pipelines successfully started running 6 pipeline(s).

souvikghosh04

@copilot please address the review comments from my side. also add some unit test coverage.

souvikghosh04 · 2026-02-11T08:07:17Z

src/Service/HealthCheck/Utilities.cs

+                        return new SqlConnectionStringBuilder(connectionString).ToString();
+                    default:
+                        return connectionString;
+                }


@copilot for sake of completeness, should you also normalize MySQL connection string?

Added MySQL connection string normalization in commit d94b703. The method now uses MySqlConnectionStringBuilder for MySQL databases, consistent with the pattern used for PostgreSQL and MSSQL.

souvikghosh04 · 2026-02-11T08:08:13Z

src/Service/HealthCheck/Utilities.cs

+                // If the connection string cannot be parsed by the builder,
+                // return the original string to avoid failing the health check.
+                return connectionString;
+            }


@copilot at least log the exception or throw them instead of swallowing silently

Added logging in commit d94b703. The method now accepts an optional ILogger parameter and logs warnings when connection string parsing fails. The logger is passed from HttpUtilities where it's already available, providing visibility into parsing failures without exposing sensitive data in the connection string.

Co-authored-by: souvikghosh04 <210500244+souvikghosh04@users.noreply.github.com>

Copilot · 2026-02-11T08:32:28Z

@copilot please address the review comments from my side. also add some unit test coverage.

Added comprehensive unit test coverage in commit d94b703. Created HealthCheckUtilitiesUnitTests.cs with 9 test cases covering:

PostgreSQL, MSSQL, DWSQL, and MySQL normalization
PostgreSQL lowercase keywords (the specific bug reported)
Unsupported database types
Malformed connection strings with/without logger
Empty connection strings

All tests pass successfully (9/9).

Initial plan

d4424e0

Copilot AI assigned Copilot and JerryNixon Jan 27, 2026

Copilot started work on behalf of JerryNixon January 27, 2026 16:47 View session

Fix PostgreSQL health check connection string handling

66b22b8

Co-authored-by: JerryNixon <1749983+JerryNixon@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix health check error for postgres data-source~~ Fix PostgreSQL health check connection string parsing Jan 27, 2026

Copilot AI requested a review from JerryNixon January 27, 2026 16:59

Copilot finished work on behalf of JerryNixon January 27, 2026 16:59

JerryNixon marked this pull request as ready for review January 27, 2026 20:12

Copilot AI review requested due to automatic review settings January 27, 2026 20:12

JerryNixon requested review from Alekhya-Polavarapu, Aniruddh25, RubenCerna2079, aaronburtle, anushakolan, neeraj-sharma2592, rusamant, sourabh1007, souvikghosh04 and vadeveka as code owners January 27, 2026 20:12

Copilot started reviewing on behalf of JerryNixon January 27, 2026 20:13 View session

JerryNixon approved these changes Jan 27, 2026

View reviewed changes

JerryNixon unassigned Copilot Jan 27, 2026

JerryNixon added pgsql an issue thats specific to pgsql cri Customer Reported issue labels Jan 27, 2026

JerryNixon added this to Data API builder Jan 27, 2026

github-project-automation bot moved this to Todo in Data API builder Jan 27, 2026

JerryNixon moved this from Todo to Review In Progress in Data API builder Jan 27, 2026

JerryNixon added this to the Feb 2026 milestone Jan 27, 2026

JerryNixon moved this from Review In Progress to In Progress in Data API builder Jan 27, 2026

JerryNixon assigned souvikghosh04 Jan 27, 2026

Copilot AI reviewed Jan 27, 2026

View reviewed changes

Copilot started work on behalf of JerryNixon January 30, 2026 20:27 View session

Add exception handling to NormalizeConnectionString method

d858f2d

Co-authored-by: JerryNixon <1749983+JerryNixon@users.noreply.github.com>

Copilot finished work on behalf of JerryNixon February 2, 2026 16:09

Merge branch 'main' into copilot/fix-health-check-postgres

209087a

Merge branch 'main' into copilot/fix-health-check-postgres

26096f1

souvikghosh04 reviewed Feb 11, 2026

View reviewed changes

Copilot started work on behalf of souvikghosh04 February 11, 2026 08:24 View session

Add MySQL support, logging, and unit tests for NormalizeConnectionString

d94b703

Co-authored-by: souvikghosh04 <210500244+souvikghosh04@users.noreply.github.com>

Copilot AI requested a review from souvikghosh04 February 11, 2026 08:33

Copilot finished work on behalf of souvikghosh04 February 11, 2026 08:33

Fix PostgreSQL health check connection string parsing #3083

Are you sure you want to change the base?

Fix PostgreSQL health check connection string parsing #3083

Conversation

Copilot AI commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Fix PostgreSQL health check connection string handling

Summary

Changes (4 files, 204 lines added, 3 lines modified):

Review Feedback Addressed

Security Summary

Comments on the Issue (you are @copilot in this section)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

JerryNixon commented Jan 30, 2026

Uh oh!

Copilot AI commented Jan 30, 2026

Uh oh!

Aniruddh25 commented Feb 11, 2026

Uh oh!

azure-pipelines bot commented Feb 11, 2026

Uh oh!

souvikghosh04 commented Feb 11, 2026

Uh oh!

azure-pipelines bot commented Feb 11, 2026

Uh oh!

souvikghosh04 left a comment

Choose a reason for hiding this comment

Uh oh!

souvikghosh04 Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

souvikghosh04 Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Feb 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Jan 27, 2026 •

edited

Loading