[AutoPR azure-mgmt-fabric]-generated-from-SDK Generation - Python-6671798 - #48489
[AutoPR azure-mgmt-fabric]-generated-from-SDK Generation - Python-6671798#48489azure-sdk-automation[bot] wants to merge 4 commits into
Conversation
…ic/Fabric/tspconfig.yaml', SDK Release Type: stable, and CommitSHA: 'a11c8d40bf2ab8aed7c8debec9528bff36a7ae2a' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6670686 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
|
Azure Pipelines: Successfully started running 1 pipeline(s). 10 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
Pull request overview
Note
Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.
Updates the azure-mgmt-fabric Python management SDK generation to a newer Fabric ARM spec (2026-08-01-preview), including packaging modernization and new API surface (e.g., usages listing).
Changes:
- Switches packaging from
setup.py/sdk_packaging.tomltopyproject.toml(PEP 517/621 style) and updates Python support metadata. - Regenerates client/operations/models for API version
2026-08-01-preview, adding capacity overage + quota/usages support. - Updates generated samples/tests and embedded metadata (
api.md, apiview properties, generator metadata).
Reviewed changes
Copilot reviewed 53 out of 53 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/fabric/azure-mgmt-fabric/tsp-location.yaml | Points codegen to new spec directory + commit. |
| sdk/fabric/azure-mgmt-fabric/setup.py | Removes legacy setuptools setup.py packaging entrypoint. |
| sdk/fabric/azure-mgmt-fabric/sdk_packaging.toml | Removes standalone packaging metadata (moved into pyproject.toml). |
| sdk/fabric/azure-mgmt-fabric/pyproject.toml | Introduces PEP 517 build config + project metadata + packaging table. |
| sdk/fabric/azure-mgmt-fabric/generated_tests/test_fabric_mgmt_fabric_capacities_operations_async.py | Updates request payload shape (overage) + adds list usages test. |
| sdk/fabric/azure-mgmt-fabric/generated_tests/test_fabric_mgmt_fabric_capacities_operations.py | Updates request payload shape (overage) + adds list usages test. |
| sdk/fabric/azure-mgmt-fabric/generated_samples/operations_list.py | Updates x-ms-original-file reference to new API version. |
| sdk/fabric/azure-mgmt-fabric/generated_samples/fabric_capacities_update.py | Updates sample payload for overage + x-ms-original-file reference. |
| sdk/fabric/azure-mgmt-fabric/generated_samples/fabric_capacities_suspend.py | Updates x-ms-original-file reference to new API version. |
| sdk/fabric/azure-mgmt-fabric/generated_samples/fabric_capacities_resume.py | Updates x-ms-original-file reference to new API version. |
| sdk/fabric/azure-mgmt-fabric/generated_samples/fabric_capacities_list_usages_by_subscription.py | Adds new sample for list_usages. |
| sdk/fabric/azure-mgmt-fabric/generated_samples/fabric_capacities_list_skus_for_capacity.py | Updates x-ms-original-file reference to new API version. |
| sdk/fabric/azure-mgmt-fabric/generated_samples/fabric_capacities_list_skus.py | Updates x-ms-original-file reference to new API version. |
| sdk/fabric/azure-mgmt-fabric/generated_samples/fabric_capacities_list_by_subscription.py | Updates x-ms-original-file reference to new API version. |
| sdk/fabric/azure-mgmt-fabric/generated_samples/fabric_capacities_list_by_resource_group.py | Updates x-ms-original-file reference to new API version. |
| sdk/fabric/azure-mgmt-fabric/generated_samples/fabric_capacities_get.py | Updates x-ms-original-file reference to new API version. |
| sdk/fabric/azure-mgmt-fabric/generated_samples/fabric_capacities_delete.py | Updates x-ms-original-file reference to new API version. |
| sdk/fabric/azure-mgmt-fabric/generated_samples/fabric_capacities_create_or_update.py | Updates sample payload for overage + x-ms-original-file reference. |
| sdk/fabric/azure-mgmt-fabric/generated_samples/fabric_capacities_check_name_availability.py | Updates x-ms-original-file reference to new API version. |
| sdk/fabric/azure-mgmt-fabric/azure/mgmt/fabric/types.py | Adds TypedDict request/response type definitions (overage, quota, etc.). |
| sdk/fabric/azure-mgmt-fabric/azure/mgmt/fabric/operations/_patch.py | Updates boilerplate + typing style for patch exports. |
| sdk/fabric/azure-mgmt-fabric/azure/mgmt/fabric/operations/_operations.py | Regenerates sync operations for new API version + adds list_usages. |
| sdk/fabric/azure-mgmt-fabric/azure/mgmt/fabric/operations/init.py | Adjusts import order/type-checking around patch exports. |
| sdk/fabric/azure-mgmt-fabric/azure/mgmt/fabric/models/_patch.py | Updates boilerplate + typing style for patch exports. |
| sdk/fabric/azure-mgmt-fabric/azure/mgmt/fabric/models/_models.py | Regenerates models, adding overage and quota models and updating base model usage. |
| sdk/fabric/azure-mgmt-fabric/azure/mgmt/fabric/models/_enums.py | Adds CapacityOverageState enum and punctuation fixes. |
| sdk/fabric/azure-mgmt-fabric/azure/mgmt/fabric/models/init.py | Updates exported models/enums including new overage/quota types. |
| sdk/fabric/azure-mgmt-fabric/azure/mgmt/fabric/aio/operations/_patch.py | Updates boilerplate + typing style for async patch exports. |
| sdk/fabric/azure-mgmt-fabric/azure/mgmt/fabric/aio/operations/_operations.py | Regenerates async operations for new API version + adds list_usages. |
| sdk/fabric/azure-mgmt-fabric/azure/mgmt/fabric/aio/operations/init.py | Adjusts async operations imports/type-checking around patch exports. |
| sdk/fabric/azure-mgmt-fabric/azure/mgmt/fabric/aio/_patch.py | Updates boilerplate + typing style for async package patch exports. |
| sdk/fabric/azure-mgmt-fabric/azure/mgmt/fabric/aio/_configuration.py | Updates configuration for new API version + introduces cloud setting plumbing. |
| sdk/fabric/azure-mgmt-fabric/azure/mgmt/fabric/aio/_client.py | Updates async client to derive ARM endpoints from cloud settings. |
| sdk/fabric/azure-mgmt-fabric/azure/mgmt/fabric/aio/init.py | Adjusts import order/type-checking around patch exports. |
| sdk/fabric/azure-mgmt-fabric/azure/mgmt/fabric/_version.py | Bumps package version to 1.1.0. |
| sdk/fabric/azure-mgmt-fabric/azure/mgmt/fabric/_validation.py | Adds API-version gating decorator used by newly introduced methods. |
| sdk/fabric/azure-mgmt-fabric/azure/mgmt/fabric/_utils/init.py | Introduces utils package placeholder for regenerated helpers. |
| sdk/fabric/azure-mgmt-fabric/azure/mgmt/fabric/_serialization.py | Refactors serialization/deserialization internals and typing. |
| sdk/fabric/azure-mgmt-fabric/azure/mgmt/fabric/_patch.py | Updates boilerplate + typing style for package patch exports. |
| sdk/fabric/azure-mgmt-fabric/azure/mgmt/fabric/_model_base.py | Significant model base refactor (serialization/deserialization, XML helpers, failsafe deserialization). |
| sdk/fabric/azure-mgmt-fabric/azure/mgmt/fabric/_configuration.py | Updates configuration for new API version + introduces cloud setting plumbing. |
| sdk/fabric/azure-mgmt-fabric/azure/mgmt/fabric/_client.py | Updates sync client to derive ARM endpoints from cloud settings. |
| sdk/fabric/azure-mgmt-fabric/azure/mgmt/fabric/init.py | Adjusts import order/type-checking around patch exports. |
| sdk/fabric/azure-mgmt-fabric/azure/mgmt/init.py | Adds # type: ignore to pkgutil namespace extension. |
| sdk/fabric/azure-mgmt-fabric/azure/init.py | Adds # type: ignore to pkgutil namespace extension. |
| sdk/fabric/azure-mgmt-fabric/apiview-properties.json | Adds cross-language APIView mapping metadata. |
| sdk/fabric/azure-mgmt-fabric/api.metadata.yml | Adds API parser/generator metadata. |
| sdk/fabric/azure-mgmt-fabric/api.md | Adds generated public API surface description. |
| sdk/fabric/azure-mgmt-fabric/_metadata.json | Adds codegen metadata for spec, versions, and emitter. |
| sdk/fabric/azure-mgmt-fabric/_meta.json | Removes legacy codegen metadata file. |
| sdk/fabric/azure-mgmt-fabric/README.md | Updates minimum supported Python version and auth wording. |
| sdk/fabric/azure-mgmt-fabric/MANIFEST.in | Updates sdist include rules (tests/samples + typing marker). |
| sdk/fabric/azure-mgmt-fabric/CHANGELOG.md | Adds 1.1.0 release entry with placeholders/warnings. |
Suppressed comments (1)
sdk/fabric/azure-mgmt-fabric/pyproject.toml:1
[project].licenseas a plain string is not PEP 621 compliant for many build backends/tooling (it is generally expected to be a table likelicense = { text = \"MIT\" }orlicense = { file = \"LICENSE\" }). This can cause build/metadata validation failures with stricter tooling; consider switching to the table form.
[Pilot] PR Pipeline Failure AnalysisA CI pipeline failed on this pull request. Here is an automated analysis of what went wrong and how to get the build green. What failedThe Verify Changelog task in the public CI pipeline failed for Recommended next steps
Raw pipeline analysis (azsdk ci analyze)
|
|
Hi @samarths-msft, the package is configured as stable (version 1.1.0 with is_stable = true), but the target API version is 2026-08-01-preview. Stable packages should target a non-preview API version. Could you provide context on whether this mismatch is intentional? |
ChenxiJiang333 this may be an error on my part in the release plan? Currently Fabric has a stable API version (2023-11-01), and we are trying to spin up a new preview version (2026-08-01-preview). Do I need to change release plan? Or any change needed in the azure-rest-api-specs PR? Please advise on next steps. Not sure how to change this SDK Release Type: |
It's not a big deal. Since you confirmed the target api version is preview. I'll just regenerate the code with release type |
…ic/Fabric/tspconfig.yaml', SDK Release Type: beta, and CommitSHA: '2c275e5b4f834495b2dc99c0ed162436f38686bd' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6671798 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 53 out of 53 changed files in this pull request and generated 3 comments.
Suppressed comments (7)
sdk/fabric/azure-mgmt-fabric/azure/mgmt/fabric/operations/init.py:1
- This wildcard import no longer suppresses
pylint: disable=unused-wildcard-import(it was present before). If pylint is part of CI, this will reintroduce lint failures. Add the pylint suppression back on the runtime wildcard import (and apply the same fix to the similar__init__.pyfiles undermodels/,aio/, andaio/operations/).
sdk/fabric/azure-mgmt-fabric/generated_tests/test_fabric_mgmt_fabric_capacities_operations.py:1 - The new
list_usagestest useslocation=\"str\", which is not a valid Azure region and is likely to fail in live/record mode. Use a real location (e.g.,AZURE_LOCATIONor the preparer-providedresource_group.location) so the test can run reliably. (Make the corresponding change in the async test as well.)
sdk/fabric/azure-mgmt-fabric/generated_tests/test_fabric_mgmt_fabric_capacities_operations.py:1 - The new
list_usagestest is a pure smoke test with no assertions. Since this is newly added behavior, add minimal validations (e.g., assert the pager yields items, or that yielded items have expected keys likecurrent_value/limit/unit) to ensure regressions are caught rather than only exercising the call path.
sdk/fabric/azure-mgmt-fabric/CHANGELOG.md:3 - The changelog currently includes both
1.1.0b1and1.1.0sections for the same date, but the package version is set to1.1.0b1in_version.py. This is confusing for consumers and release tooling. Please remove the1.1.0section (or update it to match the actual released version), and replace the tool warning lines with real release notes under the correct version heading.
## 1.1.0b1 (2026-08-07)
sdk/fabric/azure-mgmt-fabric/CHANGELOG.md:20
- The changelog currently includes both
1.1.0b1and1.1.0sections for the same date, but the package version is set to1.1.0b1in_version.py. This is confusing for consumers and release tooling. Please remove the1.1.0section (or update it to match the actual released version), and replace the tool warning lines with real release notes under the correct version heading.
## 1.1.0 (2026-08-07)
WARNING: Stable SDK version 1.1.0 is used with preview API version 2026-08-01-preview. If this is expected, delete this line; otherwise, check this PR.
tool can't generate changelog for this release, please update manually.
sdk/fabric/azure-mgmt-fabric/azure/mgmt/fabric/_configuration.py:40
- The docstring advertises
api_version=Nonesemantics ('use the operation default'), but the implementation always defaultsapi_versionto a concrete string and stores it as astr. If callers passapi_version=None, it will be propagated into request builders and the version validator, which can lead to incorrect behavior. Either (mandatory) update the docs to match the implementation, or (preferred) changeapi_versiontoOptional[str]and normalizeNoneto the intended default behavior before requests are built. (Same issue exists in the async configuration.)
:keyword api_version: The API version to use for this operation. Known values are
"2026-08-01-preview" and None. Default value is None. If not set, the operation's default API
version will be used. Note that overriding this default value may result in unsupported
behavior.
sdk/fabric/azure-mgmt-fabric/azure/mgmt/fabric/_configuration.py:52
- The docstring advertises
api_version=Nonesemantics ('use the operation default'), but the implementation always defaultsapi_versionto a concrete string and stores it as astr. If callers passapi_version=None, it will be propagated into request builders and the version validator, which can lead to incorrect behavior. Either (mandatory) update the docs to match the implementation, or (preferred) changeapi_versiontoOptional[str]and normalizeNoneto the intended default behavior before requests are built. (Same issue exists in the async configuration.)
api_version: str = kwargs.pop("api_version", "2026-08-01-preview")
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 53 out of 53 changed files in this pull request and generated no new comments.
Suppressed comments (1)
sdk/fabric/azure-mgmt-fabric/CHANGELOG.md:14
- This release raises the package requirement from Python 3.8+ to 3.10+, but the release notes do not disclose that Python 3.8 and 3.9 are no longer supported. Please call out this user-impacting compatibility change explicitly, as other packages do when increasing their minimum Python version.
## 1.1.0b1 (2026-08-07)
|
Hi, the new api version |
There was a problem hiding this comment.
Hi @Samarth Shah (@samarths-msft), we have approved the PR. You can move on to merge and release though the action suggestion in Release Plan.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 53 out of 53 changed files in this pull request and generated no new comments.
Suppressed comments (1)
sdk/fabric/azure-mgmt-fabric/CHANGELOG.md:5
- This release raises
requires-pythonfrom 3.8 to 3.10 and updates the README accordingly, but the release notes do not disclose that Python 3.8 and 3.9 support is being dropped. Please record this compatibility change so users see it during upgrade; current packages consistently call out minimum-Python increases in their changelogs (for example,sdk/core/azure-core/CHANGELOG.md:125-127).
## 1.1.0b1 (2026-08-07)
### Features Added


Configurations: 'specification/fabric/resource-manager/Microsoft.Fabric/Fabric/tspconfig.yaml', SDK Release Type: beta, and CommitSHA: '2c275e5b4f834495b2dc99c0ed162436f38686bd' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6671798 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://azsdk-releaseplan-dashboard-hveph5aqhhcfhtgu.westus-01.azurewebsites.net/?releaseplan=35264 Submitted by: samarths@microsoft.com