Enable OneSettings config manager in azure-monitor-opentelemetry distro - #48475
Draft
Leighton Chen (lzchen) wants to merge 2 commits into
Draft
Enable OneSettings config manager in azure-monitor-opentelemetry distro#48475Leighton Chen (lzchen) wants to merge 2 commits into
Leighton Chen (lzchen) wants to merge 2 commits into
Conversation
Bump azure-monitor-opentelemetry-exporter minimum dependency to 1.0.0b56 and contribute distro profile fields (component=dst, distro version) to the OneSettings control plane during configure_azure_monitor. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b13aa0ee-c777-4719-a18e-21985cf46358
Prevent configure_azure_monitor tests from starting the real OneSettings worker thread by patching get_configuration_manager for every test. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b13aa0ee-c777-4719-a18e-21985cf46358
|
Azure Pipelines: Successfully started running 1 pipeline(s). 10 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enables the OneSettings control plane (config manager) in the
azure-monitor-opentelemetrydistro, as a follow-up to enabling it in the exporter (#48429).Changes
1.0.0b56(the version that enabled the config manager in the exporter).configure_azure_monitor: the distro callsconfig_manager.initialize(component="dst", version=<distro version>)before any exporter is created. Because_ConfigurationProfile.fill()is first-wins per field, the distro setscomponent="dst"and the distro version, while the exporters created afterward still supplyikey/region/os/rp/attachwithout overriding these already-set fields.get_configuration_manager()None-check, so the call is skipped when the control plane is disabled via env var (consistent with the exporter).Tests
test_configure_azure_monitor_initializes_config_manager(assertsinitialize(component="dst", version=VERSION)) andtest_configure_azure_monitor_config_manager_disabled(None path).setUp-level patch ofget_configuration_managerso no distro configure test starts the real OneSettings worker thread.All 27
test_configure.pytests pass; black clean.