Support no-op for PR pipeline#47578
Open
raych1 wants to merge 3 commits into
Open
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an opt-in SkipPrValidation parameter to the Python PR pipeline so that a manually-queued run can short-circuit normal PR/CI validation and execute only a lightweight no-op stage. This is useful for forcing a pipeline run (e.g., to refresh required-check status) without paying the cost of full validation. Automatic, PR-triggered runs are unaffected because the skip is additionally gated on Build.Reason == 'Manual'.
Changes:
- Adds a
SkipPrValidationboolean parameter (defaultfalse) to bothpullrequest.ymland thearchetype-sdk-client.ymltemplate, threading it through. - Conditionally inserts a
NoOpstage (compile-time) and skips theBuildstage (runtimecondition) / release template (compile-time) whenSkipPrValidationis true on a manual run.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
eng/pipelines/pullrequest.yml |
Declares the new SkipPrValidation parameter and forwards it to the archetype template. |
eng/pipelines/templates/stages/archetype-sdk-client.yml |
Accepts SkipPrValidation, adds a NoOp stage, and gates the Build stage and release template on the skip condition. |
Notes from review:
- I verified
variables['Build.Reason']is valid in compile-time${{ if }}expressions here (widely used, e.g.check-spelling.yml:37,archetype-python-release.yml:356) and that the runtimeeq(${{ parameters.<bool> }}, true)pattern has precedent (docindex.yml:122), so the change is functionally correct across the manual-skip, manual-normal, and PR-triggered cases. - One non-blocking nit: the
Buildgate uses a runtimecondition:while theNoOpand release gates use compile-time${{ if }}; unifying them would fully omitBuild(rather than showing it as skipped) and keep the three identical conditions consistent.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
benbp
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Validation