Skip to content

Add aiohttp to apiview requirements to fix API.md consistency check#47544

Open
EldertGrootenboer wants to merge 5 commits into
mainfrom
fix/apiview-reqs-add-aiohttp
Open

Add aiohttp to apiview requirements to fix API.md consistency check#47544
EldertGrootenboer wants to merge 5 commits into
mainfrom
fix/apiview-reqs-add-aiohttp

Conversation

@EldertGrootenboer

Copy link
Copy Markdown
Member

Problem

The API.md Consistency check (apistub / apiview-stub-generator) builds the API stub by importing the whole package. For azure-servicebus, importing azure.servicebus.aio.management._management_client_async eagerly imports AioHttpTransport from azure.core.pipeline.transport, which requires aiohttp. The apiview requirements environment did not include aiohttp, so stub generation failed with:

ModuleNotFoundError: No module named 'aiohttp'

This made the consistency check fail on any azure-servicebus PR (and any other package whose import graph reaches AioHttpTransport), blocking merges.

Fix

Add aiohttp to eng/apiview_reqs.txt so the API.md consistency environment can import packages that reference the aiohttp-based transport.

Notes

Extracted from #45142 so this engineering-environment fix lands independently of the feature change.

Co-authored-by: EldertGrootenboer <19503614+EldertGrootenboer@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 17, 2026 17:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds aiohttp to the API.md consistency (apiview stub generation) requirements so packages that import AioHttpTransport can be imported successfully during stub generation in CI.

Changes:

  • Add a pinned aiohttp dependency to eng/apiview_reqs.txt used by the API.md consistency workflow.

@EldertGrootenboer EldertGrootenboer enabled auto-merge (squash) June 17, 2026 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants