-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Sync eng/common directory with azure-sdk-tools for PR 14420 #45668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
azure-sdk
wants to merge
8
commits into
main
Choose a base branch
from
sync-eng/common-azsdk-benchmark-pipeline-14420
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2862fd9
benchmark template
jeo02 b654120
cli args instead of args
jeo02 ae6e36c
target path
jeo02 1577e53
.net 9
jeo02 294ce3d
fix
jeo02 14b7f57
blank defaults
jeo02 928d63b
back to 8
jeo02 5ca6d54
install after checkout
jeo02 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,79 @@ | ||||||
| parameters: | ||||||
| - name: BenchmarkProject | ||||||
| type: string | ||||||
| default: 'tools/azsdk-cli/Azure.Sdk.Tools.Cli.Benchmarks' | ||||||
| - name: ScenarioName | ||||||
| type: string | ||||||
| default: ' ' | ||||||
| - name: Tags | ||||||
| type: string | ||||||
| default: ' ' | ||||||
| - name: Model | ||||||
| type: string | ||||||
| default: ' ' | ||||||
| - name: Parallelism | ||||||
| type: number | ||||||
| default: 5 | ||||||
|
|
||||||
| jobs: | ||||||
| - job: Run_Benchmark | ||||||
| variables: | ||||||
| - template: /eng/pipelines/templates/variables/globals.yml | ||||||
| - template: /eng/pipelines/templates/variables/image.yml | ||||||
| - group: 'AzSDK_Eval_Variable_group' | ||||||
| displayName: 'Run Benchmark' | ||||||
| pool: | ||||||
| name: $(LINUXPOOL) | ||||||
| image: $(LINUXVMIMAGE) | ||||||
| os: linux | ||||||
|
|
||||||
| steps: | ||||||
| - checkout: none | ||||||
|
|
||||||
| - template: /eng/common/pipelines/templates/steps/sparse-checkout.yml | ||||||
| parameters: | ||||||
| SkipCheckoutNone: true | ||||||
| Repositories: | ||||||
| - Name: $(Build.Repository.Name) | ||||||
| Commitish: $(Build.SourceVersion) | ||||||
| WorkingDirectory: $(System.DefaultWorkingDirectory)/$(Build.Repository.Name) | ||||||
| Paths: | ||||||
| - '${{ parameters.BenchmarkProject }}/**' | ||||||
| - 'eng/common/**' | ||||||
|
|
||||||
| - template: /eng/pipelines/templates/steps/install-dotnet.yml | ||||||
|
|
||||||
| - task: PowerShell@2 | ||||||
| displayName: 'Run benchmarks' | ||||||
| condition: succeeded() | ||||||
| inputs: | ||||||
| targetType: 'inline' | ||||||
| workingDirectory: '$(System.DefaultWorkingDirectory)/$(Build.Repository.Name)/${{ parameters.BenchmarkProject }}' | ||||||
| pwsh: true | ||||||
| script: | | ||||||
| $cliArgs = @("run") | ||||||
|
|
||||||
| # Determine scenario selection: name, tags, or all | ||||||
| if ("${{ parameters.ScenarioName }}".Trim()) { | ||||||
| $cliArgs += "${{ parameters.ScenarioName }}".Trim() | ||||||
| } elseif ("${{ parameters.Tags }}".Trim()) { | ||||||
| $cliArgs += "--tags", "${{ parameters.Tags }}".Trim() | ||||||
| } else { | ||||||
| $cliArgs += "--all" | ||||||
| } | ||||||
|
|
||||||
| # Optional model override | ||||||
| if ("${{ parameters.Model }}".Trim()) { | ||||||
| $cliArgs += "--model", "${{ parameters.Model }}".Trim() | ||||||
| } | ||||||
|
|
||||||
| $cliArgs += "--parallel", "${{ parameters.Parallelism }}" | ||||||
| $cliArgs += "--cleanup", "always" | ||||||
|
|
||||||
| Write-Host "Running: dotnet run -- $($cliArgs -join ' ')" | ||||||
| dotnet run -- @cliArgs | ||||||
|
||||||
| dotnet run -- @cliArgs | |
| dotnet run -- $cliArgs |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This job references
/eng/pipelines/templates/steps/install-dotnet.yml, but that template file doesn’t exist in this repo (there’s noinstall-dotnet.ymlundereng/pipelines/templates/steps/). If this job is ever invoked, the pipeline will fail at template-expansion time. Either add/sync the missing step template into this repo, or replace this include with the explicit UseDotNet tasks (as done inai-eval-job.yml) so the job is self-contained.