[agentserver] Add unit tests for tools in core and langgraph packages

sdk/agentserver/azure-ai-agentserver-agentframework/azure/ai/agentserver/agentframework/_foundry_tools.py

@@ -13,7 +13,7 @@
 
 from azure.ai.agentserver.core import AgentServerContext
 from azure.ai.agentserver.core.logger import get_logger
-from azure.ai.agentserver.core.tools import FoundryToolLike, ResolvedFoundryTool
+from azure.ai.agentserver.core.tools import FoundryToolLike, ResolvedFoundryTool, ensure_foundry_tool
 
 logger = get_logger()
 
@@ -45,7 +45,7 @@ def __init__(
         self,
         tools: Sequence[FoundryToolLike],
     ) -> None:
-        self._allowed_tools: List[FoundryToolLike] = list(tools)
+        self._allowed_tools: List[FoundryToolLike] = [ensure_foundry_tool(tool) for tool in tools]
 
     async def list_tools(self) -> List[AIFunction]:
         server_context = AgentServerContext.get()
@@ -71,7 +71,7 @@ def _to_aifunction(self, foundry_tool: "ResolvedFoundryTool") -> AIFunction:
         # Build field definitions for the Pydantic model
         field_definitions: Dict[str, Any] = {}
         for field_name, field_info in properties.items():
-            field_type = self._json_schema_type_to_python(field_info.type or "string")
+            field_type = field_info.type.py_type
             field_description = field_info.description or ""
             is_required = field_name in required_fields
 
@@ -107,24 +107,6 @@ async def tool_func(**kwargs: Any) -> Any:
             input_model=input_model
         )
 
-    def _json_schema_type_to_python(self, json_type: str) -> type:
-        """Convert JSON schema type to Python type.
-
-        :param json_type: The JSON schema type string.
-        :type json_type: str
-        :return: The corresponding Python type.
-        :rtype: type
-        """
-        type_map = {
-            "string": str,
-            "number": float,
-            "integer": int,
-            "boolean": bool,
-            "array": list,
-            "object": dict,
-        }
-        return type_map.get(json_type, str)
-
 
 class FoundryToolsChatMiddleware(ChatMiddleware):
     """Chat middleware to inject Foundry tools into ChatOptions on each call."""

sdk/agentserver/azure-ai-agentserver-agentframework/tests/unit_tests/agent_framework/__init__.py

@@ -0,0 +1,5 @@
+# ---------------------------------------------------------
+# Copyright (c) Microsoft Corporation. All rights reserved.
+# ---------------------------------------------------------
+
+__path__ = __import__('pkgutil').extend_path(__path__, __name__)

sdk/agentserver/azure-ai-agentserver-core/azure/ai/agentserver/core/tools/__init__.py

@@ -15,6 +15,7 @@
     FoundryConnectedTool,
     FoundryHostedMcpTool,
     FoundryTool,
+    FoundryToolDetails,
     FoundryToolProtocol,
     FoundryToolSource,
     ResolvedFoundryTool,
@@ -47,6 +48,7 @@
     "FoundryConnectedTool",
     "FoundryHostedMcpTool",
     "FoundryTool",
+    "FoundryToolDetails",
     "FoundryToolProtocol",
     "FoundryToolSource",
     "ResolvedFoundryTool",

sdk/agentserver/azure-ai-agentserver-core/azure/ai/agentserver/core/tools/runtime/_facade.py

@@ -1,6 +1,7 @@
 # ---------------------------------------------------------
 # Copyright (c) Microsoft Corporation. All rights reserved.
 # ---------------------------------------------------------
+import re
 from typing import Any, Dict, Union
 
 from .. import FoundryConnectedTool, FoundryHostedMcpTool
@@ -45,6 +46,48 @@ def ensure_foundry_tool(tool: FoundryToolLike) -> FoundryTool:
         if not isinstance(project_connection_id, str) or not project_connection_id:
             raise InvalidToolFacadeError(f"project_connection_id is required for tool protocol {protocol}.")
 
-        return FoundryConnectedTool(protocol=protocol, project_connection_id=project_connection_id)
+        # Parse the connection identifier to extract the connection name
+        connection_name = _parse_connection_id(project_connection_id)
+        return FoundryConnectedTool(protocol=protocol, project_connection_id=connection_name)
     except ValueError:
         return FoundryHostedMcpTool(name=tool_type, configuration=tool)
+
+
+# Pattern for Azure resource ID format:
+# /subscriptions/<sub>/resourceGroups/<rg>/providers/Microsoft.CognitiveServices/accounts/<account>/projects/<project>/connections/<name>
+_RESOURCE_ID_PATTERN = re.compile(
+    r"^/subscriptions/[^/]+/resourceGroups/[^/]+/providers/Microsoft\.CognitiveServices/"
+    r"accounts/[^/]+/projects/[^/]+/connections/(?P<name>[^/]+)$",
+    re.IGNORECASE,
+)
+
+
+def _parse_connection_id(connection_id: str) -> str:
+    """Parse the connection identifier and extract the connection name.
+
+    Supports two formats:
+    1. Simple name: "my-connection-name"
+    2. Resource ID: "/subscriptions/<sub>/resourceGroups/<rg>/providers/Microsoft.CognitiveServices/accounts/<account>/projects/<project>/connections/<name>"
+
+    :param connection_id: The connection identifier, either a simple name or a full resource ID.
+    :type connection_id: str
+    :return: The connection name extracted from the identifier.
+    :rtype: str
+    :raises InvalidToolFacadeError: If the connection_id format is invalid.
+    """
+    if not connection_id:
+        raise InvalidToolFacadeError("Connection identifier cannot be empty.")
+
+    # Check if it's a resource ID format (starts with /)
+    if connection_id.startswith("/"):
+        match = _RESOURCE_ID_PATTERN.match(connection_id)
+        if not match:
+            raise InvalidToolFacadeError(
+                f"Invalid resource ID format for connection: '{connection_id}'. "
+                "Expected format: /subscriptions/<sub>/resourceGroups/<rg>/providers/"
+                "Microsoft.CognitiveServices/accounts/<account>/projects/<project>/connections/<name>"
+            )
+        return match.group("name")
+
+    # Otherwise, treat it as a simple connection name
+    return connection_id

sdk/agentserver/azure-ai-agentserver-core/tests/unit_tests/core/__init__.py

@@ -0,0 +1,5 @@
+# ---------------------------------------------------------
+# Copyright (c) Microsoft Corporation. All rights reserved.
+# ---------------------------------------------------------
+
+__path__ = __import__('pkgutil').extend_path(__path__, __name__)

sdk/agentserver/azure-ai-agentserver-core/tests/unit_tests/core/tools/__init__.py

@@ -0,0 +1,4 @@
+# ---------------------------------------------------------
+# Copyright (c) Microsoft Corporation. All rights reserved.
+# ---------------------------------------------------------
+

sdk/agentserver/azure-ai-agentserver-core/tests/unit_tests/core/tools/client/__init__.py

@@ -0,0 +1,5 @@
+# ---------------------------------------------------------
+# Copyright (c) Microsoft Corporation. All rights reserved.
+# ---------------------------------------------------------
+
+__path__ = __import__('pkgutil').extend_path(__path__, __name__)

sdk/agentserver/azure-ai-agentserver-core/tests/unit_tests/core/tools/client/operations/__init__.py

@@ -0,0 +1,4 @@
+# ---------------------------------------------------------
+# Copyright (c) Microsoft Corporation. All rights reserved.
+# ---------------------------------------------------------
+