-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[Storage] STG 101 Beta Release Prep #44807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Storage] STG 101 Beta Release Prep #44807
Conversation
API Change CheckAPIView identified API level changes in this PR and created the following API reviews azure-storage-blob |
sdk/storage/azure-storage-blob/azure/storage/blob/_generated/aio/_azure_blob_storage.py
Show resolved
Hide resolved
|
/azp run python - storage - tests |
|
The build extended failure was just bad luck :( |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sdk/storage/azure-storage-blob/azure/storage/blob/aio/_blob_client_async.py
Outdated
Show resolved
Hide resolved
| self._raw_credential = credential if credential else sas_token | ||
| self._query_str, credential = self._format_query_string(sas_token, credential) | ||
| super(ContainerClient, self).__init__(parsed_url, service='blob', credential=credential, **kwargs) | ||
| self._api_version = get_api_version(kwargs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency with async change, remove this line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left it here because we need it for _build_generated_client
| ) | ||
| self._client = AzureQueueStorage(self.url, base_url=self.url, pipeline=self._pipeline, loop=loop) | ||
| self._client._config.version = get_api_version(api_version) # type: ignore [assignment] | ||
| self._api_version = get_api_version(api_version) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this.
93d2356
into
Azure:feature/storage-stg101
No description provided.