Skip to content

Rename client building function to _build_dummy_client for clarity #44802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
howieleung wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Rename client building function to _build_dummy_client for clarity #44802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sdk/ai/azure-ai-projects/tests/responses/test_responses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def patch_openai(monkeypatch):
monkeypatch.setattr("azure.ai.projects._patch.get_bearer_token_provider", lambda *_, **__: "token-provider")


def _build_client(
def _build_dummy_client(
project_user_agent: Optional[str],
default_headers: Optional[Dict[str, str]],
):
Expand Down Expand Up @@ -104,7 +104,7 @@ def test_responses(self, **kwargs):
],
)
def test_user_agent_patching_via_response_create(self, project_ua, openai_default_header, expected_ua):
client = _build_client(project_ua, openai_default_header)
client = _build_dummy_client(project_ua, openai_default_header)

calls = []

Expand Down
4 changes: 2 additions & 2 deletions sdk/ai/azure-ai-projects/tests/responses/test_responses_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ async def get_token(self, *scopes: str, **kwargs: Any): # type: ignore[override
return AccessToken("token", 0)


def _build_client(
def _build_dummy_client(
project_user_agent: Optional[str],
default_headers: Optional[Dict[str, str]],
):
Expand Down Expand Up @@ -95,7 +95,7 @@ async def test_responses_async(self, **kwargs):
)
@pytest.mark.asyncio
async def test_user_agent_patching_via_response_create(self, project_ua, openai_default_header, expected_ua):
client = _build_client(project_ua, openai_default_header)
client = _build_dummy_client(project_ua, openai_default_header)

calls = []

Expand Down
Loading