-
Notifications
You must be signed in to change notification settings - Fork 3.2k
App Config Fixing + Adding Samples #44790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds Entra ID authentication samples and fixes issues in the App Configuration SDK samples to enable live execution. The changes update parameter names (credential_scopes to audience), reorganize imports, and enhance snapshot samples to create necessary configuration settings before snapshot operations.
Changes:
- Added new hello_world_entra_id_sample.py demonstrating Entra ID authentication
- Updated Bleu sample to use
audienceparameter instead ofcredential_scopes - Enhanced snapshot samples to create required settings before snapshot creation
- Reorganized imports to follow Python best practices
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| hello_world_entra_id_sample.py | New sample demonstrating Entra ID authentication (has documentation issues) |
| hello_world_sample_entra_id_and_bleu.py | Updated to use audience parameter and reorganized imports |
| snapshot_sample.py | Enhanced to create settings before snapshot, but critical code is commented out |
| async_snapshot_sample.py | Properly implements async snapshot creation with all necessary settings |
sdk/appconfiguration/azure-appconfiguration/samples/hello_world_entra_id_sample.py
Outdated
Show resolved
Hide resolved
sdk/appconfiguration/azure-appconfiguration/samples/hello_world_entra_id_sample.py
Outdated
Show resolved
Hide resolved
sdk/appconfiguration/azure-appconfiguration-provider/samples/snapshot_sample.py
Outdated
Show resolved
Hide resolved
sdk/appconfiguration/azure-appconfiguration-provider/samples/snapshot_sample.py
Outdated
Show resolved
Hide resolved
sdk/appconfiguration/azure-appconfiguration-provider/samples/snapshot_sample.py
Outdated
Show resolved
Hide resolved
sdk/appconfiguration/azure-appconfiguration/samples/hello_world_entra_id_sample.py
Outdated
Show resolved
Hide resolved
sdk/appconfiguration/azure-appconfiguration/samples/hello_world_entra_id_sample.py
Outdated
Show resolved
Hide resolved
sdk/appconfiguration/azure-appconfiguration/samples/hello_world_entra_id_sample.py
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Description