Skip to content

Conversation

@azure-sdk
Copy link
Collaborator

@azure-sdk azure-sdk commented Jan 21, 2026

Configurations: 'specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/Registry/tspconfig.yaml', API Version: 2025-11-01, SDK Release Type: stable, and CommitSHA: 'eb320d1d85f5b46c3cfe6cf60a1f0de4ef3b01d9' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5777145 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=1857cf38-61f6-f011-8406-000d3a5c46b0 Submitted by: clarkporter@microsoft.com

Release Plan Details

…rosoft.ContainerRegistry/Registry/tspconfig.yaml', API Version: 2025-11-01, SDK Release Type: stable, and CommitSHA: 'eb320d1d85f5b46c3cfe6cf60a1f0de4ef3b01d9' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5777145 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
- Model `ConnectedRegistryUpdateParameters` deleted or renamed its instance variable `garbage_collection`
- Model `CredentialSetUpdateParameters` deleted or renamed its instance variable `auth_credentials`
- Model `OperationDefinition` deleted or renamed its instance variable `service_specification`
- Model `RegistryUpdateParameters` deleted or renamed its instance variable `admin_user_enabled`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CodeJourneys Are these unflattened changes expected?
In the newly generated SDK, RegistryUpdateParameters has a nested structure:

class RegistryUpdateParameters:
    properties: RegistryPropertiesUpdateParameters  # Nested
    identity: IdentityProperties
    tags: dict[str, str]
    sku: Sku

However, the current SDK uses flattened properties where all update parameters inherit directly from RegistryPropertiesUpdateParameters: https://github.com/azure-sdk/azure-sdk-for-python/blob/main/sdk/containerregistry/azure-mgmt-containerregistry/azure/mgmt/containerregistry/models/_models_py3.py#L4728C1-L4729C1

This structural change would require changes on cli side when consuming the new SDK

Copy link

@CodeJourneys CodeJourneys Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msyyc - Could you confirm expected structure given the azure-mgmt-containerregistry split in this PR and the corresponding tasks PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lizMSFT I get your concern. Yeah, there is structure change since we release from Typespec which introduces new model type. But SDK team have also designed black magic to keep compatible with existing SDK models so we expect there is actually no runtime behavior change for these models.

NOTE: If needed, SDK team could prepare private package before public release for CLI team in advance so that CLI team could have more time to take the adoption work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants