Stop overriding X_VCPKG_ASSET_SOURCES from a secret variable - #7322
Open
Daniel Jurek (danieljurek) wants to merge 1 commit into
Open
Stop overriding X_VCPKG_ASSET_SOURCES from a secret variable#7322Daniel Jurek (danieljurek) wants to merge 1 commit into
Daniel Jurek (danieljurek) wants to merge 1 commit into
Conversation
X_VCPKG_ASSET_SOURCES is being moved off the azuresdkartifacts storage account and onto the Microsoft-hosted Terrapin source mirror, which needs no SAS token and is therefore not a secret. eng/common's set-vcpkg-cache-vars.yml now sets X_VCPKG_ASSET_SOURCES directly and no longer defines X_VCPKG_ASSET_SOURCES_SECRET. Mapping the removed secret variable into the step env would shadow the value set by eng/common, so drop the mapping and let the job-level variable flow through. VCPKG_BINARY_SOURCES still carries a SAS token in internal builds and keeps its secret mapping. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 951b5748-dd8c-4a3d-83a1-958b2f6a484d
Daniel Jurek (danieljurek)
requested review from
Ben Broderick Phillips (benbp) and
Mike Harder (mikeharder)
as code owners
August 13, 2026 18:56
|
Azure Pipelines: Successfully started running 2 pipeline(s). 8 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Copilot started reviewing on behalf of
Daniel Jurek (danieljurek)
August 13, 2026 18:57
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Azure Pipelines CMake build step template to stop mapping X_VCPKG_ASSET_SOURCES from a secret pipeline variable, with the intent of relying on a non-secret X_VCPKG_ASSET_SOURCES value set elsewhere.
Changes:
- Removed the
X_VCPKG_ASSET_SOURCES: $(X_VCPKG_ASSET_SOURCES_SECRET)environment mapping from thecmake generatestep. - Kept the
VCPKG_BINARY_SOURCESsecret mapping unchanged.
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
72
to
75
| displayName: cmake generate | ||
| env: | ||
| VCPKG_BINARY_SOURCES: $(VCPKG_BINARY_SOURCES_SECRET) | ||
| X_VCPKG_ASSET_SOURCES: $(X_VCPKG_ASSET_SOURCES_SECRET) | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
X_VCPKG_ASSET_SOURCESis moving off the azuresdkartifacts storage account andonto the Microsoft-hosted Terrapin source mirror, which carries no SAS token and
is therefore not a secret. eng/common now sets
X_VCPKG_ASSET_SOURCESdirectlyand no longer defines
X_VCPKG_ASSET_SOURCES_SECRET, so mapping that removedvariable into the step env would shadow the value eng/common sets.
X_VCPKG_ASSET_SOURCES: $(X_VCPKG_ASSET_SOURCES_SECRET)env mappingVCPKG_BINARY_SOURCESstill carries a SAS token and keeps its secret mappingRelated: Azure/azure-sdk-tools#16724