Sync eng/common directory with azure-sdk-tools for PR 16705 - #7320
Open
azure-sdk-automation[bot] wants to merge 2 commits into
Open
Sync eng/common directory with azure-sdk-tools for PR 16705#7320azure-sdk-automation[bot] wants to merge 2 commits into
azure-sdk-automation[bot] wants to merge 2 commits into
Conversation
azure-sdk-automation
Bot
added
EngSys
|
Azure Pipelines: Successfully started running 5 pipeline(s). 5 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.
Refactors Azure DevOps pipeline steps by extracting inline PowerShell into reusable scripts, and introduces a shared staging script for uploading test results as “llm-artifacts”.
Changes:
- Replaced inline
pwshblocks for test-proxy install/start/healthcheck withPowerShell@2tasks calling new shared scripts. - Added
Copy-TestResultsToLlmStaging.ps1and updated the upload template to use it. - Updated the PR diff generation step to run via
filePathinstead of inline script execution.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| eng/common/testproxy/test-proxy-tool.yml | Switches inline PowerShell to PowerShell@2 tasks and delegates to shared scripts for test-proxy lifecycle. |
| eng/common/scripts/Test-TestProxyIsAlive.ps1 | New script to poll /Admin/IsAlive with retries. |
| eng/common/scripts/Start-TestProxy.ps1 | New script to start test-proxy on Windows and set PROXY_PID. |
| eng/common/scripts/Install-TestProxy.ps1 | New script to install/configure the test-proxy tool and set pipeline variables. |
| eng/common/scripts/Copy-TestResultsToLlmStaging.ps1 | New script to locate and stage test result files into llm-artifacts. |
| eng/common/pipelines/templates/steps/upload-llm-artifacts.yml | Replaces inline staging logic with a call to Copy-TestResultsToLlmStaging.ps1. |
| eng/common/pipelines/templates/steps/save-package-properties.yml | Updates PR diff generation to use filePath invocation. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Alan Zimmer (alzimmermsft)
approved these changes
Aug 12, 2026
Ben Broderick Phillips (benbp)
approved these changes
Aug 12, 2026
azure-sdk-automation
Bot
force-pushed
the
sync-eng-common-MoveSomeInlineScriptsToCheckedInFiles-16705
branch
from
August 12, 2026 20:13
ea8af0f to
8f57de9
Compare
Ben Broderick Phillips (benbp)
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#16705 See eng/common workflow