Added AMQP Decimal support to C++ AMQP stack. - #7314
Open
Larry Osterman (LarryOsterman) wants to merge 5 commits into
Open
Added AMQP Decimal support to C++ AMQP stack.#7314Larry Osterman (LarryOsterman) wants to merge 5 commits into
Larry Osterman (LarryOsterman) wants to merge 5 commits into
Conversation
|
Azure Pipelines: Successfully started running 2 pipeline(s). 8 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Larry Osterman (LarryOsterman)
requested review from
Johnathan W (j7nw4r) and
Sagar Patel (sagar0207)
August 11, 2026 21:18
Larry Osterman (LarryOsterman)
marked this pull request as ready for review
August 11, 2026 21:21
Larry Osterman (LarryOsterman)
requested a review
from Rick Winter (RickWinter)
as a code owner
August 11, 2026 21:22
Larry Osterman (LarryOsterman)
requested review from
Anton Kolesnyk (antkmsft) and
Jeff Fisher (xirzec)
as code owners
August 11, 2026 21:22
|
Azure Pipelines: Successfully started running 2 pipeline(s). 8 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Copilot started reviewing on behalf of
Larry Osterman (LarryOsterman)
August 11, 2026 21:22
View session
Larry Osterman (LarryOsterman)
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Adds end-to-end support for AMQP decimal scalar types (decimal32/64/128) across the azure-core-amqp C++ model layer and both underlying implementations (uAMQP C vendor stack and the Rust stack), including serialization/deserialization and unit test coverage.
Changes:
- Introduces
AmqpDecimal32/64/128aliases and newAmqpValueTypevariants, plus C++AmqpValueconstructors/conversions for these types. - Extends uAMQP vendor code to create/get/encode/decode/compare decimal values and updates stringification support.
- Extends the Rust AMQP value model + FFI wrapper + fe2o3 conversions to handle decimal values, and adds C++ unit tests for creation, container round-trips, and serialize/deserialize.
Reviewed changes
Copilot reviewed 6 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/core/azure-core-amqp/test/ut/amqp_value_tests.cpp | Adds unit tests for decimal value creation, conversion behavior, container round-trips, and serialize/deserialize. |
| sdk/core/azure-core-amqp/src/models/amqp_value.cpp | Adds decimal type printing/mappings and C++ constructors/conversion operators for decimal values. |
| sdk/core/azure-core-amqp/src/impl/uamqp/vendor/azure-uamqp-c/src/amqpvalue.c | Adds uAMQP decimal storage, create/get APIs, equality support, encoding, and decoding support. |
| sdk/core/azure-core-amqp/src/impl/uamqp/vendor/azure-uamqp-c/src/amqpvalue_to_string.c | Adds uAMQP decimal formatting in amqpvalue_to_string. |
| sdk/core/azure-core-amqp/src/impl/uamqp/vendor/azure-uamqp-c/inc/azure_uamqp_c/amqpvalue.h | Declares uAMQP decimal create/get APIs. |
| sdk/core/azure-core-amqp/src/impl/uamqp/vendor/azure-uamqp-c/inc/azure_uamqp_c/amqp_types.h | Adds decimal AMQP types to the uAMQP internal type enum. |
| sdk/core/azure-core-amqp/src/impl/rust_amqp/rust_amqp/rust_wrapper/src/model/value.rs | Extends Rust FFI wrapper with decimal type tagging and create/get APIs for decimals. |
| sdk/core/azure-core-amqp/src/impl/rust_amqp/rust_amqp/azure_core_amqp/src/value.rs | Extends Rust AmqpValue enum and conversion macros for decimal arrays. |
| sdk/core/azure-core-amqp/src/impl/rust_amqp/rust_amqp/azure_core_amqp/src/fe2o3/value.rs | Adds fe2o3 <-> AmqpValue conversions and tests for decimals. |
| sdk/core/azure-core-amqp/inc/azure/core/amqp/models/amqp_value.hpp | Adds public C++ API surface for decimals (types, constructors, conversions) and minor formatting cleanup. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
361
to
+363
| AmqpValue::AmqpValue(std::uint8_t byte_value) | ||
| : m_impl{std::make_unique<AmqpValueImpl>( | ||
| _detail::UniqueAmqpValueHandle{amqpvalue_create_ubyte(byte_value)})} | ||
| _detail::UniqueAmqpValueHandle{amqpvalue_create_ubyte(byte_value)})} |
Member
Author
There was a problem hiding this comment.
Copilot The code compiles on Windows, Linux and Mac, can you help me understand where this is a problem?
Larry Osterman (LarryOsterman)
force-pushed
the
larryo/fixed_7310
branch
from
August 12, 2026 17:18
0a2971f to
903f8df
Compare
Larry Osterman (LarryOsterman)
requested review from
Josue Gomez (SwayGom),
Eric Lam (MSFT) (hmlam) and
SJ (sjkwak)
as code owners
August 12, 2026 21:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed issue #7310
Added support for Decimal AMQP types to the Rust and uAMQP stacks.