Update Azure.Identity to 1.21.0 by isra-fel · Pull Request #29654 · Azure/azure-powershell

isra-fel · 2026-05-20T18:02:44Z

Description

This pull request primarily upgrades key dependencies across multiple modules to their latest versions and makes several related code adjustments to ensure compatibility. It also clarifies build instructions and introduces minor code refactoring for improved type clarity and maintainability.

Mandatory Checklist

Please choose the target release of Azure PowerShell. (⚠️Target release is a different concept from API readiness. Please click below links for details.)
- General release
- Public preview
- Private preview
- Engineering build
- No need for a release
Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

SHOULD update ChangeLog.md file(s) appropriately
- Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
  - A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
- Should not change ChangeLog.md if no new release is required, such as fixing test case only.
SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
SHOULD have proper test coverage for changes in pull request.
SHOULD NOT adjust version of module manually in pull request

azure-client-tools-bot-prd · 2026-05-20T18:02:48Z

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copilot

Pull request overview

This PR updates shared/authentication-related dependencies used across Azure PowerShell (primarily those shipped/loaded via Az.Accounts) and applies small code adjustments in several modules to resolve type/namespace ambiguities introduced by the dependency bumps.

Changes:

Bumped shared/runtime dependency set (Azure.Core/Azure.Identity/MSAL/System.* and related transitive deps) and refreshed the Az.Accounts conditional assembly loading inventory.
Updated several modules’ code to fully-qualify Identity model types to avoid ambiguous references.
Added a repo agent guide for the standard shared-dependency update workflow and documented the dependency changes in Az.Accounts’ changelog.

Reviewed changes

Copilot reviewed 29 out of 60 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
tools/Common.Netcore.Dependencies.targets	Updates compile-time Azure.Core reference version.
src/lib/manifest.json	Updates the shared dependency manifest (versions, TFMs, adds new transitive deps).
src/Accounts/AssemblyLoading/ConditionalAssemblyProvider.cs	Regenerates/updates the shared assembly load list/versions for Az.Accounts.
src/lib/cgmanifest.json	Updates component governance manifest to match updated shared dependencies.
src/Accounts/Authentication/Authentication.csproj	Bumps Azure.Identity/Azure.Identity.Broker/MSAL compile-time references.
src/Accounts/Authenticators/Factories/AzureCredentialFactory.cs	Updates Managed Identity credential construction and suppresses obsolete API warnings.
src/Accounts/Authenticators/SilentAuthenticator.cs	Adds scoped obsolete-warning suppressions around SharedTokenCache credential options.
src/Accounts/Authenticators/UsernamePasswordAuthenticator.cs	Adds scoped obsolete-warning suppression (with a TODO to migrate).
src/Accounts/Accounts/ChangeLog.md	Adds Upcoming Release notes for dependency upgrades.
.github/agents/dependencyUpdate.agent.md	Adds guidance for contributors on updating shared dependencies via AzDev.
src/Storage/Storage.Management/StorageAccount/SetAzureStorageAccount.cs	Fully qualifies Storage `Identity` usage to resolve conflicts.
src/Storage/Storage.Management/StorageAccount/NewAzureStorageAccount.cs	Fully qualifies Storage `Identity` usage to resolve conflicts.
src/Storage/Storage.Management/Models/PSStorageAccount.cs	Fully qualifies Storage `Identity` property type.
src/Search/Search/SearchService/SetSearchServiceCommand.cs	Resolves `Identity` ambiguity via namespace alias/cast.
src/Search/Search/SearchService/NewSearchServiceCommand.cs	Resolves `Identity` ambiguity via namespace alias/cast.
src/Search/Search/Models/PSIdentity.cs	Updates explicit conversion operators to use a namespace alias for `Identity`.
src/Resources/Resources/Resources.csproj	Updates Microsoft.Extensions.DependencyInjection.Abstractions reference.
src/Resources/ResourceManager/SdkModels/Resources/PSResource.cs	Fully qualifies ResourceManager `Identity` to resolve conflicts.
src/RecoveryServices/RecoveryServices/RecoveryServices.csproj	Updates System.Security.Cryptography.Cng package reference.
src/KeyVault/KeyVault/KeyVault.csproj	Updates System.Security.Cryptography.Cng package reference.
src/IotHub/IotHub/IotHub.csproj	Updates Microsoft.Extensions.DependencyInjection.Abstractions reference.
src/DataFactory/DataFactoryV1/DataFactoryV1.csproj	Updates System.IO.FileSystem.AccessControl package reference.
src/OperationalInsights/OperationalInsights/Models/PSIdentity.cs	Fully qualifies OperationalInsights `Identity` to resolve conflicts.
src/CognitiveServices/CognitiveServices/Models/PSCognitiveServicesAccount.cs	Fully qualifies CognitiveServices `Identity` property type.
src/CognitiveServices/CognitiveServices/CognitiveServicesAccount/SetAzureCognitiveServicesAccount.cs	Fully qualifies CognitiveServices `Identity` instantiation.
src/CognitiveServices/CognitiveServices/CognitiveServicesAccount/NewAzureCognitiveServicesAccount.cs	Fully qualifies CognitiveServices `Identity` instantiation.
src/Automation/Automation/Model/AutomationAccount.cs	Fully qualifies Automation `Identity` property type.
src/Automation/Automation/Common/AutomationPSClient.cs	Uses an alias to fully qualify Automation `Identity` construction.
src/ArtifactSigning/ArtifactSigning/ArtifactSigning.csproj	Updates System.Formats.Asn1 package reference.

Comments suppressed due to low confidence (1)

src/Accounts/Accounts/ChangeLog.md:27

In the Upcoming Release notes, “MSAL” is introduced without expansion. Per changelog guidance, please expand less-obvious acronyms on first use in the release section (e.g., “MSAL (Microsoft Authentication Library)”).

* Upgraded `System.Text.Json` dependency from 8.0.6 to 10.0.3.
* Upgraded MSAL dependencies (`Microsoft.Identity.Client`, `Microsoft.Identity.Client.Extensions.Msal`, `Microsoft.Identity.Client.Broker`) from 4.83.1 to 4.84.0.

Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Copilot

Pull request overview

Copilot reviewed 28 out of 54 changed files in this pull request and generated 2 comments.

@@ -13,6 +13,7 @@
 // ----------------------------------------------------------------------------------

 using Microsoft.Azure.Management.Search.Models;


MaddyMicrosoft · 2026-05-25T03:33:18Z

        public virtual TokenCredential CreateManagedIdentityCredential(string clientId)
        {
-            return new ManagedIdentityCredential(clientId);
+            return string.IsNullOrEmpty(clientId)


Double checked this wont change behaviour. Confirmed null or empty ClientId will result in the same outcome.

github-actions · 2026-05-25T04:20:11Z

‼️ DO NOT MERGE THIS PR ‼️
This PR was labeled "Do Not Merge" because it contains code change that cannot be merged. Please contact the reviewer for more information.

isra-fel · 2026-05-25T05:21:11Z

This PR targets an out-of-band release after 16.0.0

Copilot

Pull request overview

Copilot reviewed 28 out of 54 changed files in this pull request and generated 1 comment.

…ork assembly handling

Copilot

Pull request overview

Copilot reviewed 31 out of 57 changed files in this pull request and generated 2 comments.

            "System.Text.Encodings.Web",
-            "System.Text.Json" //TODO: Compare Version along with Azure.Core
+            "System.Text.Json", //TODO: Compare Version along with Azure.Core
+            "System.ComponentModel.Annotations",


Copilot

Pull request overview

Copilot reviewed 31 out of 57 changed files in this pull request and generated 4 comments.

isra-fel

There's some misalignment among the files - the idea is src/lib/manifest.json being the single source of truth and generate the other source files based on it. Check out https://github.com/Azure/azure-powershell/blob/main/src/lib/README.md

isra-fel · 2026-06-01T06:17:46Z

                CreateAssembly("netstandard2.0", "System.ClientModel", "1.12.0.0"),
                CreateAssembly("netstandard2.0", "System.Formats.Asn1", "8.0.0.0").WithWindowsPowerShell(),
-                CreateAssembly("netstandard2.0", "System.IO.Pipelines", "10.0.0.0").WithWindowsPowerShell(),
+                CreateAssembly("netstandard2.0", "System.IO.Pipelines", "10.0.0.0"),


Do we want to remove WithWindowsPowerShell? Without it, we will be serving our own System.IO.Pipelines.dll on PS 7.4+. Can we reuse what comes with PS?

My understanding is the issue is PS7 is in net 8 which comes with version 8.0.0.0 of System.IO.Pipelines and that was causing the error in the pipeline as the upgrade means we now need 10.0.0.0

On Windows PowerShell 5.1, Connect-AzAccount failed with: Could not load file or assembly 'System.Memory, Version=4.0.5.0, ...' Newer packages (e.g. System.Text.Json 10.x) bind against System.Memory 4.0.5.0, but no NuGet System.Memory has shipped that asm version - the highest is 4.0.2.0, which Az.Accounts already carries. .NET Core / PS7 roll-forward this automatically; .NET Framework does not. Extend CustomAssemblyResolver with a narrow LowerVersionRedirectionAllowList containing only "System.Memory" so the 4.0.5.0 request is satisfied with the 4.0.2.0 DLL we ship.

Copilot

Pull request overview

Copilot reviewed 32 out of 58 changed files in this pull request and generated 3 comments.

 using Microsoft.Azure.Management.Search.Models;
+using SearchModels = Microsoft.Azure.Management.Search.Models;
 using Microsoft.WindowsAzure.Commands.Common.Attributes;


+            // Special case for System.Memory: newer packages bind against a reference
+            // version (4.0.5.0) that no NuGet System.Memory package has ever shipped.
+            // .NET Framework cannot satisfy that request on its own, so we hand back the
+            // highest shipping NuGet assembly (4.0.2.0) we already carry.
+            if (IsLowerVersionRedirectionAllowed(requested.Name))
+            {
+                return true;
+            }


…ershell into identity-1210

Copilot

Pull request overview

Copilot reviewed 32 out of 58 changed files in this pull request and generated 2 comments.

+            // Special case for System.Memory: newer packages bind against a reference
+            // version (4.0.5.0) that no NuGet System.Memory package has ever shipped.
+            // .NET Framework cannot satisfy that request on its own, so we hand back the
+            // highest shipping NuGet assembly (4.0.2.0) we already carry.
+            if (IsLowerVersionRedirectionAllowed(requested.Name))
+            {
+                return true;
+            }
+
+            return false;


Copilot

Pull request overview

Copilot reviewed 33 out of 59 changed files in this pull request and generated 2 comments.

+            // Special case for System.Memory: newer packages bind against a reference
+            // version (4.0.5.0) that no NuGet System.Memory package has ever shipped.
+            // .NET Framework cannot satisfy that request on its own, so we hand back the
+            // highest shipping NuGet assembly (4.0.2.0) we already carry.
+            if (IsLowerVersionRedirectionAllowed(requested.Name))
+            {
+                return true;
+            }


isra-fel

There's one important thing I forgot to bring up - for PS whether a module receives a new version depends on ChangeLog, so for those modules we've updated source code or csproj, we need to put something in their changelog. I'm talking about ArtifactSigning, Automation, ...Storage.

Also please check two inline comments. Rest of the PR LGTM. Thanks!

isra-fel · 2026-06-16T06:55:52Z

There are some issues in this file on main branch. Thomas is working on it. Let's wait until it's fixed and sync from main again https://github.com/Azure/azure-powershell/blob/main/src/Accounts/Accounts/ChangeLog.md

isra-fel · 2026-06-16T06:59:27Z

+        /// </summary>
+        private static bool IsLowerVersionRedirectionAllowed(string assemblyName)
+        {
+            return LowerVersionRedirectionAllowList.Contains(assemblyName);


I think the AI comments in this file make sense - we are relatively sure 4.0.2 would satisfy requests of 4.0.x, but for higher version e.g. 4.1.0 there's the risk of not being able to provide new feautres.

Copilot AI review requested due to automatic review settings May 20, 2026 18:02

Copilot started reviewing on behalf of isra-fel May 20, 2026 18:07 View session

Copilot AI reviewed May 20, 2026

View reviewed changes

Comment thread src/Accounts/Accounts/ChangeLog.md Outdated

Comment thread src/Accounts/Authentication/Authentication.csproj

Comment thread src/Accounts/Authenticators/UsernamePasswordAuthenticator.cs

Copilot AI review requested due to automatic review settings May 25, 2026 02:31

Copilot AI reviewed May 25, 2026

Update Azure.Identity to 1.21.0

ff67e1b

isra-fel force-pushed the identity-1210 branch from 5f182eb to ff67e1b Compare May 25, 2026 02:32

isra-fel marked this pull request as ready for review May 25, 2026 02:33

Copilot AI review requested due to automatic review settings May 25, 2026 02:33

isra-fel requested review from NoriZC, VeryEarly, necusjz and wangzelin007 as code owners May 25, 2026 02:33

Copilot started reviewing on behalf of isra-fel May 25, 2026 02:33 View session

Copilot AI reviewed May 25, 2026

View reviewed changes

Comment thread src/Search/Search/Models/PSIdentity.cs

@@ -13,6 +13,7 @@

// ----------------------------------------------------------------------------------

using Microsoft.Azure.Management.Search.Models;

Comment thread src/Accounts/Accounts/ChangeLog.md

MaddyMicrosoft reviewed May 25, 2026

View reviewed changes

Merge branch 'main' into identity-1210

4f49591

YanaXu added the Do Not Merge 🚫 label May 25, 2026

fix build issue CS0618

1d88e6c

Copilot AI review requested due to automatic review settings May 25, 2026 05:14

Copilot started reviewing on behalf of isra-fel May 25, 2026 05:14 View session

Copilot AI reviewed May 25, 2026

View reviewed changes

Comment thread src/Accounts/Accounts/ChangeLog.md

YanaXu removed the Do Not Merge 🚫 label May 27, 2026

MaddyMicrosoft added 2 commits May 28, 2026 09:05

tests updated to use correct constructor

fc45c82

Add System.ComponentModel.Annotations & System.Formats.Asn1 to framew…

f334428

…ork assembly handling

Copilot AI review requested due to automatic review settings May 28, 2026 01:09

Copilot started reviewing on behalf of MaddyMicrosoft May 28, 2026 01:12 View session

Copilot AI reviewed May 28, 2026

View reviewed changes

MaddyMicrosoft added 2 commits May 28, 2026 12:12

Merge branch 'main' into identity-1210

f942b5a

Load bundled System.IO.Pipelines 10.0.0.0 in both PowerShell editions

b8b974a

Copilot AI review requested due to automatic review settings May 29, 2026 01:05

Copilot started reviewing on behalf of MaddyMicrosoft May 29, 2026 01:05 View session

Copilot AI reviewed May 29, 2026

View reviewed changes

Comment thread src/Accounts/AssemblyLoading/ConditionalAssemblyProvider.cs Outdated

Comment thread src/lib/manifest.json

Comment thread src/lib/cgmanifest.json

Comment thread src/Accounts/AssemblyLoading/ConditionalAssemblyProvider.cs

isra-fel commented Jun 1, 2026

View reviewed changes

MaddyMicrosoft added 2 commits June 2, 2026 15:31

Align manifest.json

b5adb80

Copilot AI review requested due to automatic review settings June 11, 2026 05:37

Copilot started reviewing on behalf of MaddyMicrosoft June 11, 2026 05:37 View session

Copilot AI reviewed Jun 11, 2026

View reviewed changes

MaddyMicrosoft added 3 commits June 12, 2026 10:41

Merge branch 'main' into identity-1210

09bbfeb

Merge branch 'main' into identity-1210

c892cb1

Merge branch 'identity-1210' of https://github.com/isra-fel/azure-pow…

e13095c

…ershell into identity-1210

Copilot AI review requested due to automatic review settings June 12, 2026 06:02

Copilot started reviewing on behalf of MaddyMicrosoft June 12, 2026 06:03 View session

Copilot AI reviewed Jun 12, 2026

View reviewed changes

MaddyMicrosoft added 2 commits June 15, 2026 14:31

Trigger CI refresh

bed8821

Update .ci-config.json

a8d914c

Copilot AI review requested due to automatic review settings June 15, 2026 23:13

Copilot started reviewing on behalf of MaddyMicrosoft June 15, 2026 23:14 View session

Copilot AI reviewed Jun 15, 2026

View reviewed changes

isra-fel commented Jun 16, 2026

View reviewed changes

		@@ -13,6 +13,7 @@
		// ----------------------------------------------------------------------------------

		using Microsoft.Azure.Management.Search.Models;

Conversation

isra-fel commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Mandatory Checklist

Uh oh!

azure-client-tools-bot-prd Bot commented May 20, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

MaddyMicrosoft May 25, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented May 25, 2026

Uh oh!

isra-fel commented May 25, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

isra-fel left a comment

Choose a reason for hiding this comment

Uh oh!

isra-fel Jun 1, 2026

Choose a reason for hiding this comment

Uh oh!

MaddyMicrosoft Jun 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

isra-fel left a comment

Choose a reason for hiding this comment

Uh oh!

isra-fel Jun 16, 2026

Choose a reason for hiding this comment

Uh oh!

isra-fel Jun 16, 2026

isra-fel commented May 20, 2026 •

edited

Loading