feat: add docker build network option to azure.yaml#7361
Open
feat: add docker build network option to azure.yaml#7361
Conversation
Allow users to specify `docker.network` in azure.yaml service config (e.g., `network: host`) which is passed as `--network` to docker build. This enables builds behind corporate proxies that need host networking. Fixes #4758 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
spboyer
requested review from
JeffreyCA,
hemarina,
rajeshkamal5050,
tg-msft,
vhvb1989,
wbreza and
weikanglim
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for configuring Docker build networking from azure.yaml via a new services.<name>.docker.network option, enabling scenarios (like corporate proxies) that require passing --network to docker build.
Changes:
- Added a
buildNetworkparameter to(*docker.Cli).Build()and appends--network <value>when set. - Plumbed
docker.networkfromazure.yaml(DockerProjectOptions.Network) throughContainerHelperinto the Docker build invocation. - Updated both
v1.0andalphaazure.yamlJSON schemas and added unit test coverage for the new flag.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| schemas/v1.0/azure.yaml.json | Adds docker.network property to the v1.0 schema. |
| schemas/alpha/azure.yaml.json | Adds docker.network property to the alpha schema. |
| cli/azd/pkg/tools/docker/docker.go | Extends Build() to accept buildNetwork and pass --network to the build command. |
| cli/azd/pkg/tools/docker/docker_test.go | Adds a table-driven test to verify --network is included/omitted as expected. |
| cli/azd/pkg/tools/docker/acceptance/acceptance_test.go | Updates Build call site to include the new parameter. |
| cli/azd/pkg/project/framework_service_docker.go | Adds Network to DockerProjectOptions to support azure.yaml config. |
| cli/azd/pkg/project/container_helper.go | Passes dockerOptions.Network through to docker.Build(). |
Collaborator
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash: pwsh: WindowsPowerShell install MSI install Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4758
Adds a
docker.networkoption to azure.yaml service config that passes--networktodocker build. This enables builds behind corporate proxies that need host networking.Changes
docker.go— AddedbuildNetworkparam toBuild(); appends--network <value>when non-emptyframework_service_docker.go— AddedNetworkfield toDockerProjectOptionscontainer_helper.go— PassesdockerOptions.Networkthrough todocker.Build()docker_test.go— Table-driven test for network optionv1.0andalphaazure.yaml schemasUsage