{Compute} az vm update: Add test case for VM zone-movement.#33582
Open
william051200 wants to merge 2 commits into
Open
{Compute} az vm update: Add test case for VM zone-movement.#33582william051200 wants to merge 2 commits into
az vm update: Add test case for VM zone-movement.#33582william051200 wants to merge 2 commits into
Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
microsoft-github-policy-service
Bot
requested review from
yonzhan and
zhoxing-ms
microsoft-github-policy-service
Bot
added
Compute
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a regression scenario test for az vm update to ensure an existing VM’s resiliencyProfile.zoneMovement.isEnabled setting is preserved when updating unrelated properties (e.g., tags), preventing silent wiping of the zone-movement configuration.
Changes:
- Added a new scenario test
test_vm_zone_movement_preservedcovering the “update unrelated field without--zone-movement” case. - Added a new VCR recording for the new scenario test to enable reliable playback-mode execution.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/azure-cli/azure/cli/command_modules/vm/tests/latest/test_vm_commands.py |
Adds a regression test to verify zone-movement configuration is preserved across vm update operations. |
src/azure-cli/azure/cli/command_modules/vm/tests/latest/recordings/test_vm_zone_movement_preserved.yaml |
Adds the playback recording for the new test scenario. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+14803
to
+14804
| # Required Microsoft.Compute/ForceDeallocateVMPreview and Microsoft.Compute/VMAvailabilityZoneUpdate enabled | ||
| # to use --zone-movement. |
Collaborator
|
Compute |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az vm updateDescription
Ref: #33441
The purpose of this test case is to ensure
resiliencyProfile.zoneMovement.isEnablednot being silently wiped when user runaz vm updateTesting Guide
Refer to
vm\tests\latest\test_vm_commands.py-test_vm_zone_movement_preservedHistory Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.