Conversation
Member
jessejlt
commented
Nov 13, 2025
jessejlt
commented
- Improve blocked cluster federation handling
- Regenerate ADXCluster CRD
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a blocked cluster federation feature that allows excluding specific partition clusters from federation macros. This can be configured via static lists or dynamic Kusto functions.
Key changes:
- Added
BlockedClustersconfiguration to ADXCluster CRD with support for static lists and Kusto functions - Implemented endpoint normalization and filtering logic to exclude blocked clusters from federation
- Enhanced error handling in Kusto script execution to continue processing after failures
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| operator/manifests/crds/adxclusters_crd.yaml | Added CRD schema for blockedClusters configuration with static list and kustoFunction options |
| kustomize/bases/adxclusters_crd.yaml | Added same CRD schema for blockedClusters (duplicate for kustomize deployment) |
| api/v1/adxcluster_types.go | Defined Go types for BlockedClusters spec with validation patterns |
| api/v1/zz_generated.deepcopy.go | Generated DeepCopy methods for new BlockedClusters types |
| operator/adx.go | Implemented blocked cluster resolution, endpoint normalization, and schema filtering logic |
| operator/adx_test.go | Added comprehensive tests for blocked cluster functionality including edge cases |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
mkeesey
reviewed
Nov 14, 2025
Contributor
mkeesey
left a comment
mkeesey
left a comment
There was a problem hiding this comment.
Some failing tests as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.