Merged
Conversation
JB2's default 'jupyter-book build' produces a SPA (JSON content + client-side rendering) that requires a web server. GitHub Pages serves static files and gets a 404 because there's no index.html. Fix by adding --html flag which generates static HTML via server-side rendering, and update the artifact upload path from _build/site to _build/html. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Two issues causing the 404 after JB2 upgrade: 1. JB2's default build produces a SPA (JSON + client-side JS) that needs a web server. GitHub Pages serves static files -> no index.html. Fix: add --html flag to jupyter-book build. 2. Site is at azure.github.io/PyRIT/ (subpath), but assets were referenced from root (/build/...). Fix: set BASE_URL env var in the workflow per MyST deployment docs. - Makefile: jupyter-book build --all -> --all --html - docs.yml: artifact path _build/site -> _build/html - docs.yml: add BASE_URL env var using repository name Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
adrian-gavrila
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.