fix(e2e): allow DHCP INPUT rule in iptables eBPF compatibility validator#8487
Open
fix(e2e): allow DHCP INPUT rule in iptables eBPF compatibility validator#8487
Conversation
The iptables eBPF-host-routing validator rejects any iptables rule not in its allowlist. AzureLinux V3 ARM64 images have a host DHCP client rule (-A INPUT -p udp -m udp --dport 68 -j ACCEPT) that causes Test_AzureLinuxV3_ARM64/scriptless_nbc to fail consistently. This is a standard host networking rule unrelated to pod datapath or eBPF host routing. The root cause of why ARM64 has this rule while AMD64 does not needs further investigation (same iptables/nftables package versions on both architectures). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
r2k1
requested review from
AbelHu,
Devinwong,
SriHarsha001,
awesomenix,
calvin197,
cameronmeissner,
djsly,
ganeshkumarashok,
junjiezhang1997,
lilypan26,
mxj220,
pdamianov-dev,
phealy,
sulixu,
surajssd,
timmy-wright and
zachary-bailey
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the e2e iptables eBPF host routing compatibility validator to allow a standard DHCP client INPUT accept rule that appears on Azure Linux V3 ARM64 nodes, preventing consistent failures in the Test_AzureLinuxV3_ARM64/scriptless_nbc scenario.
Changes:
- Add an allowlist regex for
-A INPUT -p udp -m udp --dport 68 -j ACCEPTin the filter table patterns used byValidateIPTablesCompatibleWithCiliumEBPF.
|
I'm flattered to be mentioned in this PR, but I think you meant to tag @santhoshmprabhu 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ValidateIPTablesCompatibleWithCiliumEBPFrejects any iptables rule not in its allowlist. AzureLinux V3 ARM64 images have a host DHCP client rule that causesTest_AzureLinuxV3_ARM64/scriptless_nbcto fail consistently (5/5 builds where test reached validation).Change
Add
^-A INPUT -p udp -m udp --dport 68 -j ACCEPT$to the filter table allowlist.Details
Test_AzureLinuxV3_ARM64/scriptless_nbc— consistent, not flaky-A INPUT -p udp -m udp --dport 68 -j ACCEPT(standard DHCP client, UDP port 68)iptables-1.8.10-4.azl3andnftables-1.0.9-1.azl3packages on both, but only ARM64 has this rule. Root cause of that difference is unknown — needs node-level investigation.