chore(vhdbuilder): build ACL VHDs using marketplace images#8469
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the ACL (AzureContainerLinux) VHD build to use Azure Marketplace images as the source image (publisher/offer/sku/version) instead of sourcing from a Shared Image Gallery, and adjusts SIG image naming logic so ACL outputs keep their intended (no-prefix) SIG image definition names.
Changes:
- Switch ACL and ACL ARM64 Packer templates from Shared Image Gallery source image IDs to Marketplace image fields.
- Update
ensure_sig_image_name_linuxto avoid adding theAzureLinuxprefix forOS_SKU=AzureContainerLinuxwhenIMG_OFFER=azure-linux-3. - Add ShellSpec coverage to guard the ACL naming behavior, and update build/release pipelines to set the required
IMG_*variables.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| vhdbuilder/packer/vhd-image-builder-acl.json | Use Marketplace image (publisher/offer/sku/version) as the ACL build source instead of SIG direct image ID. |
| vhdbuilder/packer/vhd-image-builder-acl-arm64.json | Same Marketplace-source change for ACL ARM64 builds. |
| vhdbuilder/packer/produce-packer-settings-functions.sh | Prevent AzureLinux prefixing for ACL SIG image definition names despite sharing the azure-linux-3 offer. |
| spec/vhdbuilder/packer/ensure_sig_image_name_linux_spec.sh | Add tests covering ACL naming behavior under IMG_OFFER=azure-linux-3. |
| .pipelines/.vsts-vhd-builder.yaml | Set IMG_PUBLISHER/IMG_OFFER/IMG_SKU/IMG_VERSION for ACL build jobs; remove SIG source-image vars. |
| .pipelines/.vsts-vhd-builder-release.yaml | Same pipeline variable updates for release builds. |
aadhar-agarwal
force-pushed
the
aadagarwal/marketplace-acl
branch
from
783d481 to
1489d6b
Compare
aadhar-agarwal
requested review from
AbelHu,
Devinwong,
SriHarsha001,
awesomenix,
calvin197,
cameronmeissner,
djsly,
ganeshkumarashok,
junjiezhang1997,
lilypan26,
mxj220,
pdamianov-dev,
phealy,
r2k1,
sulixu,
surajssd,
timmy-wright and
zachary-bailey
as code owners
cameronmeissner
approved these changes
May 8, 2026
djsly
reviewed
May 10, 2026
| echo '##vso[task.setvariable variable=IMG_PUBLISHER]MicrosoftCBLMariner' | ||
| echo '##vso[task.setvariable variable=IMG_OFFER]azure-linux-3' | ||
| echo '##vso[task.setvariable variable=IMG_SKU]azure-linux-3-acl' | ||
| echo '##vso[task.setvariable variable=IMG_VERSION]3.20260506.01' |
Collaborator
There was a problem hiding this comment.
when will that be updated ? normally we use latest, will the ACL team be on top of this ?
Contributor
Author
There was a problem hiding this comment.
Yes, we will actively be updating this. We do want to switch to using latest soon as well - Given the product is going to GA soon, we want to be in control of the first few versions and make sure it is smooth initially.
Signed-off-by: Aadhar Agarwal <aadagarwal@microsoft.com>
aadhar-agarwal
force-pushed
the
aadagarwal/marketplace-acl
branch
from
1489d6b to
43a827f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Switch ACL VHD builds from a direct-shared SIG source to the public Azure Linux 3 marketplace images:
x64:
MicrosoftCBLMariner/azure-linux-3/azure-linux-3-aclarm64:
MicrosoftCBLMariner/azure-linux-3/azure-linux-3-arm64-gen2-aclPipelines: replace
SIG_SOURCE_*vars withIMG_PUBLISHER/OFFER/SKU/VERSIONin release and PR builders.Packer:
vhd-image-builder-acl{,-arm64}.jsonuseimage_publisher/offer/sku/versioninstead ofshared_image_gallery.direct_shared_gallery_image_id.ensure_sig_image_name_linux: skip theAzureLinuxprefix whenOS_SKU=AzureContainerLinux(ACL shares theazure-linux-3offer but its destination SIG defsaclgen2TL/aclgen2arm64TLare unprefixed). Adds ShellSpec coverage + regression guard.[TEST All VHDs] AKS Linux VHD Build - Msft Tenant - succeeded
E2Ev2 AKS RP Customized Image Validation - succeeded
Which issue(s) this PR fixes:
Fixes #