Change private registry to false so it works with GitHub/Container Apps Tutorial#32
Open
DanWahlin wants to merge 1 commit intoAzure-Samples:mainfrom
Open
Change private registry to false so it works with GitHub/Container Apps Tutorial#32DanWahlin wants to merge 1 commit intoAzure-Samples:mainfrom
DanWahlin wants to merge 1 commit intoAzure-Samples:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
Updates a single line in
deploy/main.bicep. Currently the GitHub tutorial at https://learn.microsoft.com/en-us/azure/container-apps/dapr-github-actions?tabs=bash uses this repo to demonstrate GitHub Actions and Azure Container Apps. However, thedeploy/main.bicepmarks the GitHub registry for the package astruebut it looks like that should befalse.This PR changes
isPrivateRegistrytofalseindeploy/main.bicep.How to Test
main.bicepas mentioned above). The container app revision that is created should now be able to pull the image needed and load successfully in the browser.What to Check