This repository was archived by the owner on Nov 16, 2023. It is now read-only.
updating dockerfile and readme with info on COPY and wildcards in Docker#1
Open
JamesEarle wants to merge 2 commits intoAzure-Samples:masterfrom
Open
updating dockerfile and readme with info on COPY and wildcards in Docker#1JamesEarle wants to merge 2 commits intoAzure-Samples:masterfrom
JamesEarle wants to merge 2 commits intoAzure-Samples:masterfrom
Conversation
mmacy
reviewed
Dec 14, 2017
|
|
||
| # Note | ||
|
|
||
| Most, if not all, Dockerfiles contain commands that copy your source code to the container. It is helpful to note that when copying files from your application into the container, you can use wildcard characters such as `*` and `?`. The `*` character will add all files to the destination directory that match it's pattern. The `?` character will do the same but can only be replaced by a single character. |
| d73e9071a2d0 aci-hello-world "npm start" 10 seconds ago Up 10 seconds 8080/tcp, 0.0.0.0:8080->80/tcp keen_jepsen | ||
| ``` | ||
|
|
||
| If your container has a statys of `Exited(1)` you know something has gone wrong. Take a look at your application logs using the `docker logs` command to debug. If there are any application errors, they will be shown here. |
There was a problem hiding this comment.
As this image is intended as an ACI learning vehicle, perhaps mention also how to view logs via the Azure CLI: az container logs
Also, typo: statys (status)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old notation for the Docker COPY statement in the Dockerfile does not maintain directory structure when moved to the destination folder. This is fine for the aci-helloworld sample, but any other application with files in one or more directory will break as a result of this. I've updated the sample Dockerfile and provided a bit of detail into the COPY command and wildcard characters.