Skip to content

chore(ci): fail PRs that modify labs-owned paths #25285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fcarreiro wants to merge 1 commit into
base: next
Choose a base branch
from
+25 −0
Open

chore(ci): fail PRs that modify labs-owned paths #25285

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions .github/workflows/ci3.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,31 @@ concurrency:
cancel-in-progress: true

jobs:
# Labs-owned code has moved to aztec-labs-eng/aztec-node and must not change here.
# The path list mirrors what the root Makefile's fast-labs target builds.
labs-ownership-guard:
runs-on: ubuntu-latest
if: github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork != true && github.event.pull_request.base.ref == 'next'
permissions:
pull-requests: read
steps:
- name: Fail if the PR modifies labs-owned paths
env:
GH_TOKEN: ${{ github.token }}
PR_NUMBER: ${{ github.event.pull_request.number }}
run: |
labs_paths='^(aztec-up|docs|labs-aztec-toolchain|noir-projects/labs|playground|release-image|spartan|yarn-project)/'
offending=$(gh api "repos/${{ github.repository }}/pulls/$PR_NUMBER/files" --paginate --jq '.[].filename' \
| grep -E "$labs_paths" || true)
if [ -n "$offending" ]; then
echo "Labs-owned files modified by this PR:"
echo "$offending" | sed 's/^/ /'
echo "::error::This PR tries to modify labs-owned code"
echo "Labs-owned code now lives in https://github.com/aztec-labs-eng/aztec-node - make the change there instead."
exit 1
fi
echo "No labs-owned paths modified."

# The main CI job for Aztec pull requests. It gatekeeps merges to next, intended for the merge queue.
#
# This orchestrates AWS EC2 spot instances then remotely runs ./bootstrap.sh
Expand Down
Loading