Skip to content

fix(ci): make redis_setexz a safe no-op when redis is unavailable #24520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
AztecBot wants to merge 1 commit into
base: next
Choose a base branch
from
+7 −0
Draft

fix(ci): make redis_setexz a safe no-op when redis is unavailable #24520

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ci3/source_redis
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,13 @@ function redis_cli {
}

function redis_setexz {
# No-op when redis is unavailable, but still drain stdin: otherwise the upstream
# producer feeding this pipeline gets SIGPIPE, which under `set -o pipefail` fails
# the caller (e.g. bootstrap_ec2's "CI booting..." log write killing the whole run).
if [ "$CI_REDIS_AVAILABLE" -ne 1 ]; then
cat >/dev/null
return 0
fi
gzip | redis_cli -x SETEX $1 $2 &>/dev/null
}

Expand Down
Loading