fix(archiver): tolerate re-included already-stored checkpoints#24513
Open
spalladino wants to merge 1 commit into
Open
fix(archiver): tolerate re-included already-stored checkpoints#24513spalladino wants to merge 1 commit into
spalladino wants to merge 1 commit into
Conversation
Collaborator
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Reconciling checkpoints from L1 could permanently wedge the archiver.
BlockStore.addCheckpointsaccepts an already-stored checkpoint that an L1 reorg re-included in a different L1 block (same archive root, new L1 metadata), but it filtered the already-stored prefix only locally:ArchiverDataStoreUpdater.addCheckpointsstill re-ran log and contract-data extraction for every block in the original batch. Re-presented blocks carrying aContractClassPublishedorContractInstancePublishedevent then threwalready exists, aborting the whole write transaction — the L1 sync point never advanced, so every retry re-fetched the same range and failed deterministically until manual DB cleanup.Approach
BlockStore.addCheckpointsnow returns the checkpoints it actually inserted (excluding the already-stored prefix handled byskipOrUpdateAlreadyStoredCheckpoints) instead of a boolean, and the data store updater derives the blocks for log/contract-data extraction from that suffix.Reported in AztecProtocol/aztec-claude#1288.
Fixes A-1350