refactor(aztec-nr): rename get_handshakes to non_interactive variant#24511
Merged
vezenovm merged 12 commits intoJul 6, 2026
Conversation
…f-766-handshake-facts
…d re-pin standard contracts
nchamo
added
ci-draft
Base automatically changed from
mv/f-766-handshake-facts
to
merge-train/fairies-v5
July 4, 2026 02:54
…shakes-to-get_non_interactive_handshakes Conflicts were all the get_handshakes -> get_non_interactive_handshakes / get_all_handshakes -> get_all_discovered_handshakes rename against base's newer handshake work; kept the renamed identifiers. Regenerated standard- contract artifacts are unchanged from HEAD since the merged Noir source is identical to HEAD's.
vezenovm
approved these changes
Jul 6, 2026
vezenovm
deleted the
nchamo/f-769-rename-get_handshakes-to-get_non_interactive_handshakes
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_handshakesutility toget_non_interactive_handshakes: it only returns handshakes discovered from non-interactive announcement logs, so interactive handshakes (feat(aztec-nr): add interactive handshake to the handshake registry #24473) never appear in it, and the name should say which kind it returns.Stacked on #24483.
Fixes F-769