fix(p2p): reject proposal when expected proposer is undefined#24509
Merged
PhilWindle merged 1 commit intoJul 5, 2026
Merged
Conversation
Mirrors the attestation validator: previously the proposer-identity check was skipped entirely when getProposerAttesterAddressInSlot returned undefined (empty/open committee), silently accepting any signed proposal in that case.
Collaborator
Flakey Tests🤖 says: This CI run detected 2 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
PhilWindle
approved these changes
Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Experiment to validate A-1326: when
getProposerAttesterAddressInSlotresolves toundefined,ProposalValidatorcurrently skips the proposer-identity check entirely and accepts the proposal. This applies the audit's suggested fix — reject instead of skip — mirroringCheckpointAttestationValidator, which already rejects in the equivalent case.Note:
expectedProposerresolves toundefinedspecifically when the committee is configured empty (targetCommitteeSize == 0, i.e. permissionless/open-committee mode where "anyone may propose") —sequencer.ts'scheckCanProposetreats that same case ascanPropose = truefor every node. This PR is intended to surface, via CI (in particular any multi-node/permissionless e2e coverage), whether rejecting proposals in that mode breaks anything that currently relies on it.Test plan
proposal_validator.test.ts's "open committee" cases to expect rejection instead of acceptanceyarn workspace @aztec/p2p test src/msg_validators/proposal_validator/proposal_validator.test.tspasses locally (49/49)yarn buildpasses