Skip to content

fix(proposal-handler): ensure we default to pushing blocks to archiver #24506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PhilWindle merged 1 commit into from
Jul 5, 2026
Merged

fix(proposal-handler): ensure we default to pushing blocks to archiver #24506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion yarn-project/sequencer-client/src/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ export const sequencerConfigMappings: ConfigMappingsType<SequencerConfig> = {
...booleanConfigHelper(DefaultSequencerConfig.buildCheckpointIfEmpty),
},
skipPushProposedBlocksToArchiver: {
description: 'Skip pushing proposed blocks to archiver (default: true)',
description: 'Skip pushing proposed blocks to archiver (test only)',
...booleanConfigHelper(DefaultSequencerConfig.skipPushProposedBlocksToArchiver),
},
minBlocksForCheckpoint: {
Expand Down
2 changes: 1 addition & 1 deletion yarn-project/validator-client/src/proposal_handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -591,7 +591,7 @@ export class ProposalHandler {
}

// If we succeeded, push this block into the archiver (unless disabled)
if (reexecutionResult?.block && this.config.skipPushProposedBlocksToArchiver === false) {
if (reexecutionResult?.block && !this.config.skipPushProposedBlocksToArchiver) {
await this.blockSource.addBlock(reexecutionResult.block);
}

Expand Down
Loading