test(e2e): merge single-node fee, proving, and sequencer config suites#24492
Open
spalladino wants to merge 1 commit into
Open
test(e2e): merge single-node fee, proving, and sequencer config suites#24492spalladino wants to merge 1 commit into
spalladino wants to merge 1 commit into
Conversation
Round-2 e2e consolidation (single-node merges):
- Fold fees/public_payments.test.ts (1 it) and fees/sponsored_payments.test.ts
(1 it) into fees/private_payments.parallel.test.ts as unrolled its on the
shared FeesTest+FPC fixture (adds applySponsoredFPCSetup to the beforeAll —
a PXE registration, no extra tx). Docs snippet sponsored_fpc_simple moved
verbatim; include path updated in how_to_pay_fees.md.
- Merge proving/empty_blocks, proving/world_state_pruning, and
misc/node_block_api into proving/default_node.test.ts sharing one
context-default setupWithProver({}) node. proving/cross_chain_public_message
stays put (needs sequencerPublisherAllowInvalidStates + minTxsPerBlock:1).
- Merge sequencer/slasher_config and sequencer/sequencer_config into
sequencer/runtime_config.test.ts with one setupBlockProducer carrying both
suites' config knobs.
- Convert block_building.test.ts 8-it double-spend suite into an it.each table
over {firstKind, secondKind, sameBlock, expectedError}.
Collaborator
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Round-2 e2e consolidation, PR 4 of 9 (single-node merges). All merges preserve every asserted behavior; no assertions dropped.
Merges (old → new)
single-node/fees/public_payments.test.ts+single-node/fees/sponsored_payments.test.ts→ folded intosingle-node/fees/private_payments.parallel.test.tsas two unrolled its (plain string titles — the target is.parallel). All three ran the same FeesTest+FPC fixture; the sharedbeforeAllgainsapplySponsoredFPCSetup(), which is a PXE contract registration (the SponsoredFPC is already funded at genesis viafundSponsoredFPC), not an extra tx. The folded its compute their padded-max-fee gas settings locally, matching the originals.single-node/proving/empty_blocks.test.ts+single-node/proving/world_state_pruning.test.ts+single-node/misc/node_block_api.test.ts→single-node/proving/default_node.test.ts: one context-defaultsetupWithProver({})node, one describe per former file. Ordered soworld_state_pruning(needs minTxsPerBlock:0 empty checkpoints) runs beforeempty_blocks(raises minTxsPerBlock).node_block_apiqueries the genesis block, which is setup-agnostic, so it drops its former bespoke PIPELINING setup.single-node/sequencer/slasher_config.test.ts+single-node/sequencer/sequencer_config.test.ts→single-node/sequencer/runtime_config.test.ts: onesetupBlockProducercarrying both suites' knobs (slasher inactivity config + maxL2BlockGas/manaTarget/bot account). The sequencer half keeps itssyncChainTip: 'checkpointed'via explicitpxeOptssincesetupBlockProducerdefaults to 'proposed'.single-node/block-building/block_building.test.ts: the 8-it double-spend suite is now anit.eachtable over{firstKind, secondKind, sameBlock, expectedError}(plain file, tables safe). Filename kept so the bootstrap.sh TIMEOUT=25m override and the.test_patterns.ymlentry keep applying. All other its unchanged.Container count
.parallelper-it containers: +2 (the folded fee its), each far cheaper than the full plain-file fixture they replace.it.each× 8 rows (same coverage, one title pattern).Folds skipped
single-node/proving/cross_chain_public_message.test.tsstays put: it is not default-compatible (sequencerPublisherAllowInvalidStates: true,minTxsPerBlock: 1,numberOfAccounts: 1), unlike the plan's assumption.Docs
docs/docs-developers/docs/aztec-js/how_to_pay_fees.md:#include_code sponsored_fpc_simplepath repointed toprivate_payments.parallel.test.ts; thedocs:start/end:sponsored_fpc_simpleblock moved byte-identical.Local runs
runtime_config.test.ts: 3/3 in 140sdefault_node.test.ts: 3/3 in 183sblock_building.test.ts: 18 passed / 1 skipped (pre-existing manual-only skip) in 564sprivate_payments.parallel.test.ts: 8/8 in 333sDeferred
end-to-end/README.mdexample command andsingle-node/README.mdper-file blurbs still name the old files (README sweep is deferred per the round-2 plan; PR 5+ owns it).