feat: merge-train/avm#23332
Open
AztecBot wants to merge 8 commits into
Open
Conversation
Part 1 of the immutables_hash changes as part of [AZIP-9](AztecProtocol/governance#20) This pr just adds the `immutables_hash` field to the various `ContractInstance` structs across the codebase. It also updates the `publish_contract_instance` function and bumps various constants for`ContractInstance` versions and `PXE_DATA_SCHEMA_VERSION`
AztecBot
requested review from
IlyasRidhuan,
LeilaWang,
MirandaWood,
jeanmon and
nventuro
as code owners
IlyasRidhuan
previously requested changes
May 16, 2026
Contributor
IlyasRidhuan
left a comment
IlyasRidhuan
left a comment
There was a problem hiding this comment.
Holding this train up as we want to atomically merge azip changes
Part 2 of the immutables_hash changes as part of [AZIP-9](AztecProtocol/governance#20) Updates address derivation to include the `immutables_hash`. Specifically, `immutables_hash` is now part of the `salted_initialization_hash` computation This also includes a constant update from `DOM_SEP__CONTRACT_ADDRESS_V1` -> `DOM_SEP__CONTRACT_ADDRESS_V2`
#23152) Part 3 of the immutables_hash changes as part of [AZIP-9](AztecProtocol/governance#20) This updates the `GETCONTRACTINSTANCE` opcode so that the `immutables_hash` can be retrieved from the contract instance via the opcode.
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
Implementation of [AZIP-8](https://github.com/AztecProtocol/governance/blob/main/AZIPs/azip-8.md) --------- Co-authored-by: jeanmon <jean@aztec-labs.com> Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com>
…odule with serialization changes (#23342) ### Summary This branch brings together two PRs: 1. #23155: Bumps noir - crucially includes upstream change `chore!: remove is_infinite from EmbeddedCurvePoint` 2. #22564: Top of large stack which removes `is_infinite` flag from AVM opcode and point struct PR 1 requires AVM changes in 2 to run (since it removes the `inf` flag from ACIR). For more details on specific changes see the relevant PRs above. Note that 1 is applied first so this PR will initially be identical to it, apart from any changes needed from targeting the AVM merge train. --- Will close: - [AVM Foundation Issue 13](https://linear.app/aztec-foundation/issue/AVM-13/enforce-canonical-point-at-infinity-representation) - enforce that points at inifinity are represented by `(0, 0)` - [AVM Foundation Issue 14](https://linear.app/aztec-foundation/issue/AVM-14/remove-is-inf-flag-from-avm-ec-point-representation) - remove `is_infinite` flag These issues form the bulk of the project: [Align Circuit Point Infinity Representation with Noir + BB](https://linear.app/aztec-foundation/project/align-circuit-point-infinity-representation-with-noir-bb-5564f056ac0e/overview) --------- Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com> Co-authored-by: AztecBot <tech@aztec-labs.com>
Detailed of the report is in the following gist: https://gist.github.com/AztecBot/b8be80df63afe353b576d5e9b13e70f2 We applied some mitigations for H1, M2, L1, L2, L4, L5 --------- Co-authored-by: jeanmon <jean@aztec-labs.com>
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
feat!: add immutables_hash to contract instance (#23091)
feat!: update address derivation (#23151)
feat(avm)!: add immutables_hash member to get contract instance opcode (#23152)
feat!: azip 8 public key hashes (#23159)
feat(avm)!: Remove
is_infiniteflag from AVM ECC & update noir submodule with serialization changes (#23342)fix(avm): addressing claude review of interaction builders code (#23431)
END_COMMIT_OVERRIDE