fix: register account in history note TXE tests after ALL_SCOPES removal#22170
Draft
AztecBot wants to merge 1 commit intomerge-train/fairiesfrom
Draft
fix: register account in history note TXE tests after ALL_SCOPES removal#22170AztecBot wants to merge 1 commit intomerge-train/fairiesfrom
AztecBot wants to merge 1 commit intomerge-train/fairiesfrom
Conversation
AztecBot
added
ci-draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
feat!: remove ALL_SCOPESchange (#22136) replaced'ALL_SCOPES'withkeyStore.getAccounts()in TXE session scopes, but didn't update the history note tests. These tests used a hardcodedNOTE_OWNERaddress that was never registered as an account, causing scope check failures.Fix: call
env.create_light_account()to register an account in the keystore and use its address as the note owner.Test Verification
All 13 history tests pass (5 note + 8 nullifier) after the fix.
Full analysis: https://gist.github.com/AztecBot/ebb6d0d978f5b32b8fc46a35799a28e2
ClaudeBox log: https://claudebox.work/s/85b02bc345678e42?run=1